-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce flags for NFS over REST support #2968
Open
dphulkar-msft
wants to merge
19
commits into
dphulkar/NFSOverRESTSupport
Choose a base branch
from
dphulkar/Flags
base: dphulkar/NFSOverRESTSupport
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vibhansa-msft
approved these changes
Mar 7, 2025
gapra-msft
reviewed
Mar 10, 2025
gapra-msft
reviewed
Mar 10, 2025
5 tasks
gapra-msft
reviewed
Mar 12, 2025
gapra-msft
reviewed
Mar 12, 2025
gapra-msft
reviewed
Mar 12, 2025
…ge-azcopy into dphulkar/Flags
adreed-msft
requested changes
Mar 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of little things overall here-- some repeats from the prior iteration.
vibhansa-msft
approved these changes
Mar 16, 2025
dphulkar-msft
commented
Mar 17, 2025
PreservePermissionsDisabledMsg = "Note: The preserve-permissions flag is set to false. As a result, AzCopy will not copy SMB ACLs between the source and destination. For more information, visit: https://aka.ms/AzCopyandAzureFiles." | ||
|
||
PreserveNFSPermissionsDisabledMsg = "Note: The preserve-nfs-permissions flag is set to false. As a result, AzCopy will not copy NFS permissions between the source and destination." | ||
InvalidFlagsForNFSMsg = "NFS copy cannot be used with SMB-related flags. Please use --preserve-info or --preserve-permissions flags instead." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derdanu Please help with the proper error message to be mentioned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
Issues
Team thread
Documents
[Email Subject]
Type of Change
How Has This Been Tested?
Thank you for your contribution to AzCopy!