Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce flags for NFS over REST support #2968

Open
wants to merge 19 commits into
base: dphulkar/NFSOverRESTSupport
Choose a base branch
from

Conversation

dphulkar-msft
Copy link
Member

Description

  • Feature / Bug Fix: (Brief description of the feature or issue being addressed)

  • Related Links:

  • Issues

  • Team thread

  • Documents

  • [Email Subject]

Type of Change

  • Bug fix
  • New feature
  • Documentation update required
  • Code quality improvement
  • Other (describe):

How Has This Been Tested?

Thank you for your contribution to AzCopy!

@dphulkar-msft dphulkar-msft marked this pull request as draft March 5, 2025 16:39
@dphulkar-msft dphulkar-msft marked this pull request as ready for review March 7, 2025 10:27
@dphulkar-msft dphulkar-msft mentioned this pull request Mar 11, 2025
5 tasks
Copy link
Member

@adreed-msft adreed-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of little things overall here-- some repeats from the prior iteration.

PreservePermissionsDisabledMsg = "Note: The preserve-permissions flag is set to false. As a result, AzCopy will not copy SMB ACLs between the source and destination. For more information, visit: https://aka.ms/AzCopyandAzureFiles."

PreserveNFSPermissionsDisabledMsg = "Note: The preserve-nfs-permissions flag is set to false. As a result, AzCopy will not copy NFS permissions between the source and destination."
InvalidFlagsForNFSMsg = "NFS copy cannot be used with SMB-related flags. Please use --preserve-info or --preserve-permissions flags instead."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derdanu Please help with the proper error message to be mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants