-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation on required private endpoints to access hns enabled storage #1616
Open
LizaShak
wants to merge
14
commits into
Azure:main
Choose a base branch
from
LizaShak:add-doc-on-required-pe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: support workload identity token
* create block pool in child only
* Update golang.org/x/crypto to v0.31.0
* updated year in copyright message (Azure#1601)
* Optimize HNS listing
* Added statfs for block_cache
* Add strong consistency check for data on disk
* current implementation of open file when opened in O_WRONLY will truncate the file to zero. This is incorrect behaviour. We don't see it in the normal scenario as write-back cache is on by default. Hence all the open calls with O_WRONLY will be redirected O_RDWR. To simulate this turn of the write-back cache and then open file in O_WRONLY.
* Integrating blob filter in azstorage
LizaShak
requested review from
vibhansa-msft,
souravgupta-msft,
ashruti-msft,
syeleti-msft and
jainakanksha-msft
as code owners
January 21, 2025 12:46
jainakanksha-msft
approved these changes
Jan 22, 2025
@tjvishnu : This is a documentation change, kindly review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… storage
✅ What
A section in the documentation explaining when working with HNS enables storage, you need to have the following private endpoints to access the storage.
🤔 Why
This was a missing documenation for me when I tried to configure it and spent hours trying to resolve it until I opened an issue in this repo.
👩🔬 How to validate if applicable
Since this is just a documentation then no validation needed.
🔖 Related links