Skip to content

docs: Add documentation for AKS enableWorkloadIdentity Flag #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

akhiljimmy7
Copy link

@akhiljimmy7 akhiljimmy7 commented Nov 27, 2023

Reason for Change:

If a user enables the workload identity on the AKS Cluster, there is no need for manual installation of mutating admission webhook, By enabling workload identity on the AKS Cluster it installs the mutating admission webhook components in the kube-system namespace by default.

No

Helm chart is auto-generated in Azure AD Workload Identity. If you have any changes in charts directory, they will get clobbered when we do a new release. Please see https://github.com/Azure/azure-workload-identity/blob/main/third_party/open-policy-agent/gatekeeper/helmify/static/README.md#contributing-changes for modifying the Helm chart.

No

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • [x ] no

Notes for Reviewers:

Documentation update include details enabeWorkloadIdentity flag, by updating the existing cluster by setting this flag to true, users are no longer required to install the mutating admission webhook.

https://learn.microsoft.com/en-us/azure/aks/workload-identity-deploy-cluster#update-an-existing-aks-cluster

@akhiljimmy7 akhiljimmy7 changed the title Updated the quick start guide to include details on --enable-workload… Update documentation to include changes for AKS enableWorkloadIdentity Flag Dec 1, 2023
@akhiljimmy7 akhiljimmy7 changed the title Update documentation to include changes for AKS enableWorkloadIdentity Flag docs: Add documentation for AKS enableWorkloadIdentity Flag Dec 1, 2023
@superherointj
Copy link

@akhiljimmy7 I think, you should rebase and squash commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants