feat(helm chart): Make env vars configurable and auto configure go runtime #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntime Signed-off-by: Stevo Slavic <[email protected]>
|
@microsoft-github-policy-service agree |
aramase
requested changes
Mar 27, 2025
| @@ -36,6 +36,8 @@ helm upgrade -n azure-workload-identity-system [RELEASE_NAME] azure-workload-ide | |||
| | image.pullPolicy | Image pullPolicy | `IfNotPresent` | | |||
| | image.release | The image release tag to use | Current release version: `v1.2.0` | | |||
| | imagePullSecrets | Image pull secrets to use for retrieving images from private registries | `[]` | | |||
| | goEnvVars | Go runtime environment variables to pass to the azure-wi-webhook-controller-manager's _manager_ container. | `See _values.yaml_` | | |||
There was a problem hiding this comment.
Instead of a new variable for go env vars, I would prefer just having the extra env vars with the go snippets added as example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
PR extends the workload-identity-webhook helm chart with support for configuring environment variables and it automatically configures Go runtime (GOMAXPROCS and GOMEMLIMIT) to make the runtime aware of resources assigned to the azure-wi-webhook-controller-manager Deployment containers. This reduces likelihood of CPUThrottlingHigh paging and OOM crashes.
Requirements
Issue Fixed:
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: