-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adding certificates child resource and updated max test #4682
base: main
Are you sure you want to change the base?
Conversation
params: { | ||
name: certificateObject.?name ?? 'cert-${name}' | ||
managedEnvironmentName: managedEnvironment.name | ||
certificateKeyVaultProperties: certificateKeyVaultProperties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hundredacres,
I won't block the PR over it but want to raise one question:
The certificateKeyVaultProperties
are technically a property of the certificate
child module - and could be part of the certificateObject
. However, they're instead currently decleared as a separate parameter.
What I'm wondering is, if it would be better / more intuitive to merge the parameter into the wider certificateObject
parameter (that is, merging the two parameters into one), and having line 179 and follwing simply reference the property from this location like
certificateKeyVaultProperties: !empty(certificateObject.?certificateKeyVaultProperties)
? {
identity: certificateObject!.certificateKeyVaultProperties!.identityResourceId
keyVaultUrl: certificateObject!.certificateKeyVaultProperties!.keyVaultUrl
}
: null
In general it seems a bit confusing that this and other parameters like the certificateValue
, certificatePassword
, etc. are all duplicated.
Could it be that the child is even the same as the property? If so, it may even be possible to not define the properties in line 175 and following at all, and instead have the child take care of it exclusively.
Just some thoughts. Maybe completely wrong 😄 Just wanted to ask as I got a bit confused over it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hundredacres,
did you happen to find out anything about it? Do both need to be declared? The PR already looks good as it is as far as I'm concerned. Would just be curious.
…into fix/issues/3855
This reverts commit 387ce2c.
@@ -319,4 +342,4 @@ type storageType = { | |||
|
|||
@description('Required. File share name.') | |||
shareName: string | |||
} | |||
}? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}? | |
} |
Parameter is already (correctly) nullable
Hey @hundredacres, |
Description
Added certificate child resource, updated the max test to test for it and removed unnecessary deps.
Fixes #3855
Closes #3855
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.