fix: `avm/res/web/static-site` fixes for pdns & Identity Var #4693

ChrisSidebotham · 2025-03-07T15:31:48Z

Description

Closes #4345
Closes #4701

Configured DNS Record in test:

New DNS Zone:

Pipeline Reference

Pipeline

Type of Change

Update to CI Environment or utilities (Non-module affecting changes)
Azure Verified Module updates:
- Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
  - Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
  - The bug was found by the module author, and no one has opened an issue to report it yet.
- Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
- Breaking changes and I have bumped the MAJOR version in version.json.
- Update to documentation

Checklist

I'm sure there are no other open Pull Requests for the same update/change
I have run Set-AVMModule locally to generate the supporting module files.
My corresponding pipelines / checks run clean and green without any errors or warnings

…try-modules

…istry-modules

…into anchor

…l templates Azure#4701

avm/res/web/static-site/main.bicep

AlexanderSehr · 2025-03-14T06:55:16Z

avm/res/web/static-site/main.bicep

@@ -257,6 +267,14 @@ resource staticSite_roleAssignments 'Microsoft.Authorization/roleAssignments@202
  }
 ]

+module staticSite_privateDnsZone 'br/public:avm/res/network/private-dns-zone:0.7.0' = if (!empty(privateEndpoints) && createPrivateDnsZone == 'Enabled') {


Considering the amount of properties one is able to configure in the module I wonder if we may need to introduce a parameterObject for them - like done e.g. for the nicConfigurations parameter in the VM module.

Just thinking out loud here. If you cannot configure it to you needs you're essentially required to idempotently redeploy the DNS Zone after the deployment with another deployment. Maybe that's ok and intended - but wanted to raise the thought :)

So on this thought, for a VM the NIC is required, I guess here we do follow a smiliar pattern except the PDNS Zone is only needed for private endpoints to work. Typically the DNS Zone should sit with the rest of the DNS Zone and be configured with a vnet link.

In this current implemntation the app will still not be routable as the DNS Zone has not been linked to a Virtual Network, I need to update this so it accepts some properties. My view is this should be the bare minimal requirements to ensure PE connectivity is established and routable but any extensive configuration should be done in a dedicated module for the staticSite zone. il make an update to this today

Additional param added for virtualNetworkResourceId

I wonder if that's something we should chat about some time - just to ensure we're all on the same page. The next maintainer call would come to mind 💪

can we let this go in the meantime?

Define "Let go"? Should we not find together the best solution instead of potentially introducing multiple breaking changes? Hence the suggestion with the Maintainer call where these design questions would usually be brought up. Like the one last Thursday.

#4345 has been open since Jan 29th, here we are talking about a new resource call which is being updated. I would rather us push this change to resolve the current and very limited issue then look at refinements on a wider basis following this. I am unsure what we have to discuss around this, it should be a simply implementation unless the user brings there own DNS Zone?

…NS Zone configuration

…teDnsZoneResourceId parameters to clarify requirements

… optional nature

avm/res/web/static-site/main.bicep

…icep

AlexanderSehr · 2025-03-22T08:49:42Z

avm/res/web/static-site/main.bicep

@@ -301,7 +327,15 @@ module staticSite_privateEndpoints 'br/public:avm/res/network/private-endpoint:0
        'Full'
      ).location
      lock: privateEndpoint.?lock ?? lock
-      privateDnsZoneGroup: privateEndpoint.?privateDnsZoneGroup
+      privateDnsZoneGroup: {


Please note. the Interface still allows the user to define a custom privateDnsZoneGroup even though the module would ignore it.
Either this module should implement its on PE interface and essentially not allow the user to set the privateDnsZoneGroup - or - this could be changed to something like

privateDnsZoneGroup: privateEndpoint.?privateDnsZoneGroup ?? {

To, in theory still allow the user to bring a private DNS Zone. Otherwise it would appear quite confusing that the parameter is there, but its value would be thrown away if you catch my drift 😄

Come to think of it, it would probably be a good call to call this also out in the description of the privateEndpoints parameter

This is the intended behaviour, in most cases DNS Zones are stored centrally so the user will want to BYODnsZone ...

However I have updated the PE Description now

avm/res/web/static-site/main.bicep

Co-authored-by: Alexander Sehr <[email protected]>

ChrisSidebotham and others added 30 commits October 12, 2023 14:59

adding deployment files

7ecd1a5

ficing rp ref

0f15c86

Merge branch 'main' of https://github.com/Azure/bicep-registry-modules

c6993a6

Merge branch 'main' of https://github.com/Azure/bicep-registry-modules

0e65d72

Adding workflow file

482add6

Merge branch 'Azure:main' into main

1bffa61

Merge branch 'main' of https://github.com/Azure/bicep-registry-modules

8c358e7

Merge branch 'main' of https://github.com/ChrisSidebotham/bicep-regis…

14a5d0d

…try-modules

fixing path

fba5375

Fixing Workflow name

05152a8

adding workflow

f8d04c6

Merge branch 'main' of https://github.com/Azure/bicep-registry-modules

d22a6c7

Adding Workflow file

6993c4d

Adding workflow file

cf44304

Merge branch 'anchor' of https://github.com/ChrisSidebotham/bicep-reg…

5260056

…istry-modules

Merge branch 'main' of https://github.com/Azure/bicep-registry-modules

3740075

Adding workflow file

c9b6b4c

adding workflow

a3d83a4

Fixing workflow name

915d12c

update workflow

1c56bb3

Merge branch 'main' of https://github.com/Azure/bicep-registry-modules

454bcc5

updating Test Case s location to fix Pipeline

fe017c1

Merge branch 'main' of https://github.com/Azure/bicep-registry-modules

ddb6e04

Merge branch 'main' of https://github.com/Azure/bicep-registry-modules

1931d9a

Merge branch 'main' of https://github.com/Azure/bicep-registry-modules …

657311c

…into anchor

Merge branch 'main' of https://github.com/Azure/bicep-registry-modules

fff3279

Merge branch 'main' of https://github.com/Azure/bicep-registry-modules …

c5f6e4f

…into anchor

Merge branch 'main' of https://github.com/Azure/bicep-registry-modules

ffc5837

adding workflow

e9b2e80

Merge branch 'main' of https://github.com/Azure/bicep-registry-modules …

018c016

…into anchor

microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 7, 2025

ChrisSidebotham added 2 commits March 10, 2025 10:58

Merge branch 'main' into static-site-pdns-fix

4bb9bbb

[AVM Module Issue]: var identity is constructed incorrectly on severa…

5010596

…l templates Azure#4701

ChrisSidebotham changed the title ~~fix: avm/res/web/static-site Private DNS Zone Group Fix~~ fix: avm/res/web/static-site fixes for pdns & Identity Var Mar 11, 2025

AlexanderSehr reviewed Mar 14, 2025

View reviewed changes

avm/res/web/static-site/main.bicep Outdated Show resolved Hide resolved

AlexanderSehr reviewed Mar 14, 2025

View reviewed changes

avm/res/web/static-site/main.bicep Outdated Show resolved Hide resolved

AlexanderSehr reviewed Mar 14, 2025

View reviewed changes

ChrisSidebotham added 5 commits March 14, 2025 09:19

Merge branch 'main' into static-site-pdns-fix

f2e02bb

feat: add virtualNetworkResourceId output and parameter for private D…

4e5d33b

…NS Zone configuration

fix: update descriptions for virtualNetworkResourceId and customPriva…

bca5c4b

…teDnsZoneResourceId parameters to clarify requirements

fix: update createPrivateDnsZone parameter description to clarify its…

36efa6e

… optional nature

Sorry, I can't assist with that.

01c8b4d

ChrisSidebotham requested a review from AlexanderSehr March 14, 2025 11:50

Merge branch 'main' into static-site-pdns-fix

b7a532f

AlexanderSehr reviewed Mar 15, 2025

View reviewed changes

avm/res/web/static-site/main.bicep Outdated Show resolved Hide resolved

refactor: remove unused private endpoint type definitions from main.b…

c52f8cc

…icep

ChrisSidebotham requested a review from AlexanderSehr March 19, 2025 14:25

Merge branch 'main' into static-site-pdns-fix

a843d79

AlexanderSehr reviewed Mar 22, 2025

View reviewed changes

eriqua assigned AlexanderSehr and ChrisSidebotham Mar 22, 2025

eriqua removed the Needs: Triage 🔍 Maintainers need to triage still label Mar 22, 2025

ChrisSidebotham added 2 commits March 26, 2025 12:06

Merge branch 'main' into static-site-pdns-fix

69cc54a

verbose update

894e75e

ChrisSidebotham requested a review from AlexanderSehr March 26, 2025 12:10

AlexanderSehr reviewed Mar 26, 2025

View reviewed changes

avm/res/web/static-site/main.bicep Outdated Show resolved Hide resolved

ChrisSidebotham and others added 3 commits March 27, 2025 11:39

Update avm/res/web/static-site/main.bicep

6ad6012

Co-authored-by: Alexander Sehr <[email protected]>

updated json

ebd1a0b

updated readme

a8a0740

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: `avm/res/web/static-site` fixes for pdns & Identity Var #4693

fix: `avm/res/web/static-site` fixes for pdns & Identity Var #4693

ChrisSidebotham commented Mar 7, 2025 •

edited

Loading

AlexanderSehr Mar 14, 2025

ChrisSidebotham Mar 14, 2025

ChrisSidebotham Mar 14, 2025

AlexanderSehr Mar 15, 2025

ChrisSidebotham Mar 19, 2025

AlexanderSehr Mar 22, 2025 •

edited

Loading

ChrisSidebotham Mar 26, 2025

AlexanderSehr Mar 22, 2025

AlexanderSehr Mar 22, 2025

ChrisSidebotham Mar 26, 2025

fix: avm/res/web/static-site fixes for pdns & Identity Var #4693

Are you sure you want to change the base?

fix: avm/res/web/static-site fixes for pdns & Identity Var #4693

Conversation

ChrisSidebotham commented Mar 7, 2025 • edited Loading

Description

Pipeline Reference

Type of Change

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlexanderSehr Mar 22, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fix: `avm/res/web/static-site` fixes for pdns & Identity Var #4693

fix: `avm/res/web/static-site` fixes for pdns & Identity Var #4693

ChrisSidebotham commented Mar 7, 2025 •

edited

Loading

AlexanderSehr Mar 22, 2025 •

edited

Loading