Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New module hybrid-container-service/provisioned-cluster-instance module #4720

Merged
merged 18 commits into from
Mar 27, 2025
Merged

feat: New module hybrid-container-service/provisioned-cluster-instance module #4720

merged 18 commits into from
Mar 27, 2025

Conversation

xhy8759
Copy link
Contributor

@xhy8759 xhy8759 commented Mar 13, 2025 •
edited
Loading

Description

Pipeline Reference

Pipeline
avm.res.hybrid-container-service.provisioned-cluster-instance

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@xhy8759 xhy8759 requested review from a team as code owners March 13, 2025 03:24
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Mar 13, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 13, 2025
@xhy8759
Copy link
Contributor Author

xhy8759 commented Mar 13, 2025

Why modify Action.yml: removal failed link: https://github.com/Infrastructure-as-code-Automation/bicep-registry-modules/actions/runs/13757194677

@xhy8759
Copy link
Contributor Author

xhy8759 commented Mar 21, 2025

Azure/Azure-Verified-Modules#1790

@xhy8759 xhy8759 mentioned this pull request Mar 21, 2025
Open
2 tasks
@AlexanderSehr AlexanderSehr self-assigned this Mar 22, 2025
AlexanderSehr
AlexanderSehr reviewed Mar 22, 2025
View reviewed changes
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @xhy8759, just a few smaller remarks. 💪

@AlexanderSehr AlexanderSehr self-requested a review March 25, 2025 17:42
AlexanderSehr
AlexanderSehr requested changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting for the test with the latest changes to pass @xhy8759 🤞

@AlexanderSehr AlexanderSehr merged commit 76410ab into Azure:main Mar 27, 2025
7 checks passed
@xhy8759 xhy8759 deleted the hangxu/aksarcpr branch March 27, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@AlexanderSehr AlexanderSehr

@xhy8759 xhy8759

Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xhy8759 @AlexanderSehr @DanteMustCode