Skip to content

Comments

feat: New module azure-stack-hci/virtual-machine-instance module#4722

Closed
xhy8759 wants to merge 1 commit intoAzure:mainfrom
Infrastructure-as-code-Automation:hangxu/arc-vm
Closed

feat: New module azure-stack-hci/virtual-machine-instance module#4722
xhy8759 wants to merge 1 commit intoAzure:mainfrom
Infrastructure-as-code-Automation:hangxu/arc-vm

Conversation

@xhy8759
Copy link
Contributor

@xhy8759 xhy8759 commented Mar 13, 2025

Description

Pipeline Reference

Pipeline

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@xhy8759 xhy8759 requested review from a team as code owners March 13, 2025 04:21
@avm-organizer avm-organizer bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Mar 13, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Mar 13, 2025
@microsoft-github-policy-service

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Mar 13, 2025
@microsoft-github-policy-service

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@xhy8759
Copy link
Contributor Author

xhy8759 commented Mar 13, 2025

Removal failed so modify action.yml: https://github.com/Infrastructure-as-code-Automation/bicep-registry-modules/actions/runs/13537055551

'avm/res/azure-stack-hci/logical-network' # Failing on resource deletion when trying to delete RBAC at subscription level
'avm/res/azure-stack-hci/network-interface' # Failing on resource deletion when trying to delete RBAC at subscription level
'avm/res/azure-stack-hci/virtual-hard-disk' # Failing on resource deletion when trying to delete RBAC at subscription level
'avm/res/azure-stack-hci/virtual-machine-instance' # Failing on resource deletion when trying to delete RBAC at subscription level
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. This requires manual action before merge. Just adding this comment as a placeholder to avoid the merge to go in as is after review 🙂

Comment on lines +33 to +34
- "avm/utilities/pipelines/**"
- "!avm/utilities/pipelines/platform/**"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to current path

Suggested change
- "avm/utilities/pipelines/**"
- "!avm/utilities/pipelines/platform/**"
- "utilities/pipelines/**"
- "!utilities/pipelines/platform/**"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any available extension resource for this type, e.g. locks, role assignent, private endpoint?

@AlexanderSehr
Copy link
Collaborator

Hey @xhy8759, could you give an update on this module?

@ReneHezser
Copy link
Contributor

We've just activated automatic checks for the changelog spec BCPNFR22. Please add an entry to the CHANGELOG.md.

A sample CHANGELOG.md in the module directory is:

# Changelog

The latest version of the changelog can be found [here](/Azure/bicep-registry-modules/blob/main/avm/res/aad/domain-service/CHANGELOG.md).

## 0.1.0

### Changes

- Initial Release

### Breaking Changes

- None

The new version is calculated automatically, and you must set the new version in the changelog manually. The static tests will show you the expected version if you set it to something else.

For an initial release, the version is 0.1.0

SNFR17 - Category: Release - Semantic Versioning

We are happy to help should you encounter a problem.

@eriqua
Copy link
Collaborator

eriqua commented Jul 12, 2025

Hey @xhy8759 is this still being worked on? Please let us know if you need help.

@eriqua eriqua added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author Class: Resource Module 📦 This is a resource module Nudged by AVM Team 🫵 This issue/PR has been looked at by the AVM core team and the owner has been nudged and removed Needs: Triage 🔍 Maintainers need to triage still labels Jul 12, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: No Recent Activity 💤 When an issue/PR has not been modified for X amount of days label Jul 16, 2025
@microsoft-github-policy-service

Important

@xhy8759, this issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days.

Tip

To prevent further actions to take effect, one of the following conditions must be met:

  • The author must respond in a comment within 3 days of this comment.
  • The "Status: No Recent Activity 💤" label must be removed.
  • If applicable, the "Status: Long Term ⏳" or the "Needs: Module Owner 📣" label must be added.

@xhy8759 xhy8759 closed this Jul 21, 2025
@xhy8759 xhy8759 deleted the hangxu/arc-vm branch August 13, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Class: Resource Module 📦 This is a resource module Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author Needs: Core Team 🧞 This item needs the AVM Core Team to review it Nudged by AVM Team 🫵 This issue/PR has been looked at by the AVM core team and the owner has been nudged Status: No Recent Activity 💤 When an issue/PR has not been modified for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants