Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New module azure-stack-hci/virtual-machine-instance module #4722

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: New module azure-stack-hci/virtual-machine-instance module #4722

wants to merge 1 commit into from

Conversation

xhy8759
Copy link
Contributor

@xhy8759 xhy8759 commented Mar 13, 2025

Description

Pipeline Reference

Pipeline

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@xhy8759 xhy8759 requested review from a team as code owners March 13, 2025 04:21
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Mar 13, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Mar 13, 2025
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Mar 13, 2025
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@xhy8759
Copy link
Contributor Author

xhy8759 commented Mar 13, 2025

Removal failed so modify action.yml: https://github.com/Infrastructure-as-code-Automation/bicep-registry-modules/actions/runs/13537055551

eriqua
eriqua reviewed Mar 20, 2025
View reviewed changes
.github/actions/templates/avm-validateModuleDeployment/action.yml
@@ -78,6 +78,7 @@ runs:
'avm/res/azure-stack-hci/logical-network' # Failing on resource deletion when trying to delete RBAC at subscription level
'avm/res/azure-stack-hci/network-interface' # Failing on resource deletion when trying to delete RBAC at subscription level
'avm/res/azure-stack-hci/virtual-hard-disk' # Failing on resource deletion when trying to delete RBAC at subscription level
'avm/res/azure-stack-hci/virtual-machine-instance' # Failing on resource deletion when trying to delete RBAC at subscription level
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. This requires manual action before merge. Just adding this comment as a placeholder to avoid the merge to go in as is after review 🙂

eriqua
eriqua reviewed Mar 25, 2025
View reviewed changes
.github/workflows/avm.res.azure-stack-hci.virtual-machine-instance.yml
Comment on lines +33 to +34
- "avm/utilities/pipelines/**"
- "!avm/utilities/pipelines/platform/**"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to current path

Suggested change
- "avm/utilities/pipelines/**"
- "!avm/utilities/pipelines/platform/**"
- "utilities/pipelines/**"
- "!utilities/pipelines/platform/**"

eriqua
eriqua reviewed Mar 25, 2025
View reviewed changes
avm/res/azure-stack-hci/virtual-machine-instance/main.bicep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any available extension resource for this type, e.g. locks, role assignent, private endpoint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xhy8759 @eriqua