-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Changed dataSources to optional #4762
base: main
Are you sure you want to change the base?
Conversation
According to the documentation at https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/datacollectionrules?pivots=deployment-language-bicep#datacollectionruleresourceproperties The specification of data sources. This property is optional and can be omitted if the rule is meant to be used via direct calls to the provisioned endpoint
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
@microsoft-github-policy-service agree |
@heindrichpaul thanks for your contribution. However I'm afraid we cannot merge this PR. The parameters you want to change to "Optional" are "Required" in some scenarios. You can an usage example here (Example 6: Send data to Azure Monitor Logs with Logs ingestion API) |
Description
According to the documentation at https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/datacollectionrules?pivots=deployment-language-bicep#datacollectionruleresourceproperties
The specification of data sources.
This property is optional and can be omitted if the rule is meant to be used via direct calls to the provisioned endpoint
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.