Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support private module completions #16051

Merged
merged 6 commits into from
Feb 21, 2025
Merged

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Jan 9, 2025

Fixes #9038

Microsoft Reviewers: Open in CodeFlow

@StephenWeatherford StephenWeatherford changed the title Support private module completions [WIP] Support private module completions Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test this change out locally with the following install scripts (Action run 13466619999)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 13466619999
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 13466619999"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 13466619999
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 13466619999"

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Dotnet Test Results

    78 files   -     39      78 suites   - 39   30m 42s ⏱️ - 15m 25s
11 827 tests +    82  11 827 ✅ +    82  0 💤 ±0  0 ❌ ±0 
27 412 runs   - 13 416  27 412 ✅  - 13 416  0 💤 ±0  0 ❌ ±0 

Results for commit 736e011. ± Comparison against base commit 6fcb976.

This pull request removes 2181 and adds 1094 tests. Note that renamed tests count towards both.

		nestedProp1: 1
		nestedProp2: 2
		prop1: true
		prop2: false
	1
	2
	\$'")
	prop1: true
	prop2: false
…
Bicep.Cli.IntegrationTests.BuildCommandTests ‑ Build_Valid_SingleFile_WithTemplateSpecReference_ShouldSucceed_TypedVariables_LF
Bicep.Cli.IntegrationTests.BuildCommandTests ‑ Build_Valid_SingleFile_WithTemplateSpecReference_ToStdOut_ShouldSucceed_TypedVariables_LF
Bicep.Cli.IntegrationTests.FormatCommandTests ‑ Format_SampleBicepFile_MatchesFormattedSample_TypedVariables_LF
Bicep.Cli.IntegrationTests.PublishCommandTests ‑ Publish_ValidArmTemplateFile_AllValidDataSets_ShouldSucceed_TypedVariables_LF
Bicep.Cli.IntegrationTests.PublishCommandTests ‑ TypedVariables_LF, with docUri, publishing source
Bicep.Cli.IntegrationTests.PublishCommandTests ‑ TypedVariables_LF, without docUri, not publishing source
Bicep.Cli.IntegrationTests.RestoreCommandTests ‑ Restore_ShouldSucceed ("TypedVariables_LF, not publishing source",Bicep.Core.Samples.DataSet,False)
Bicep.Cli.IntegrationTests.RestoreCommandTests ‑ Restore_ShouldSucceed ("TypedVariables_LF, publishing source",Bicep.Core.Samples.DataSet,True)
Bicep.Cli.IntegrationTests.RestoreCommandTests ‑ Restore_ShouldSucceedWithAnonymousClient ("TypedVariables_LF, not publishing source",Bicep.Core.Samples.DataSet,False)
Bicep.Cli.IntegrationTests.RestoreCommandTests ‑ Restore_ShouldSucceedWithAnonymousClient ("TypedVariables_LF, publishing source",Bicep.Core.Samples.DataSet,True)
…

♻️ This comment has been updated with latest results.

@StephenWeatherford StephenWeatherford force-pushed the sw/acr-completions branch 5 times, most recently from a447698 to 479ed50 Compare January 16, 2025 00:47
@StephenWeatherford StephenWeatherford force-pushed the sw/acr-completions branch 4 times, most recently from af65f40 to 5ea8c28 Compare January 24, 2025 18:56
@StephenWeatherford StephenWeatherford force-pushed the sw/acr-completions branch 3 times, most recently from d940471 to 704815e Compare January 31, 2025 00:42
@StephenWeatherford StephenWeatherford force-pushed the sw/acr-completions branch 7 times, most recently from 657444f to fef0f0e Compare February 5, 2025 23:56
@StephenWeatherford StephenWeatherford changed the title [WIP] Support private module completions Support private module completions Feb 5, 2025
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks for implementing this!

@StephenWeatherford StephenWeatherford merged commit b0871e8 into main Feb 21, 2025
47 checks passed
@StephenWeatherford StephenWeatherford deleted the sw/acr-completions branch February 21, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ACR (private) module reference completions
2 participants