Don't crash when nonexistent symbol is used with external inputs#19260
Merged
levimatheri merged 3 commits intomainfrom Mar 23, 2026
Merged
Don't crash when nonexistent symbol is used with external inputs#19260levimatheri merged 3 commits intomainfrom
levimatheri merged 3 commits intomainfrom
Conversation
Contributor
|
Test this change out locally with the following install scripts (Action run 23461144937) VSCode
Azure CLI
|
anthony-c-martin
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Below code was crashing language server due to unhandled exception when analyzing external input functions.
Updated
InlineParameterRewriterto explicity throwExpressionExceptionso it can be caught and handled gracefully during external input analysis.Checklist
Microsoft Reviewers: Open in CodeFlow