[Version Pinning] Enforce bicep.version compiler constraint via CompilerVersionValidator - #20299
Open
Likhitha Kodali (Likhithakmsft) wants to merge 1 commit into
Open
[Version Pinning] Enforce bicep.version compiler constraint via CompilerVersionValidator #20299Likhitha Kodali (Likhithakmsft) wants to merge 1 commit into
Likhitha Kodali (Likhithakmsft) wants to merge 1 commit into
Conversation
Contributor
|
Test this change out locally with the following install scripts (Action run 34514897641) VSCode
Azure CLI
|
Likhitha Kodali (Likhithakmsft)
changed the title
Comment on lines
+2088
to
+2094
| public Diagnostic BicepVersionConstraintNotSatisfied(string constraint, string runningVersion) => CoreError( | ||
| "BCP456", | ||
| $"The installed Bicep CLI version \"{runningVersion}\" does not satisfy the version constraint \"{constraint}\" specified by the \"bicep.version\" configuration property."); | ||
|
|
||
| public Diagnostic BicepVersionConstraintCouldNotBeChecked(string constraint, string runningVersion) => CoreWarning( | ||
| "BCP457", | ||
| $"The installed Bicep CLI version \"{runningVersion}\" could not be parsed, so the \"bicep.version\" constraint \"{constraint}\" could not be checked."); |
There was a problem hiding this comment.
Is it possible to include the bicepconfig.json file path in the error/warning message?
| } | ||
|
|
||
| [TestClass] | ||
| public class CompilerVersionValidatorEndToEndTests |
There was a problem hiding this comment.
Let's move this to Bicep.Core.IntegrationTests, where we can work with the existing TestEnvironment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a runtime check ( CompilerVersionValidator ) that validates the running Bicep CLI version against the bicep.version constraint from the effective bicepconfig.json for a single file, using the VersionRange type.
Emits
BCP456(error) when the installed version doesn't satisfy the constraint.Emits
BCP457(warning) if the running version can't be parsed, so failures are never silent.Wired into SemanticModel diagnostics ,fully backward-compatible.
Covered by unit tests ( CompilerVersionValidatorTests ) and end-to-end compilation tests ( CompilerVersionValidatorEndToEndTests ) in
CompilerVersionValidatorTests.cs.Checklist
Microsoft Reviewers: Open in CodeFlow