Add real_ps_util_renames to real_process_watchdog to avoid c_pal link in UTs#583
Open
parth21999 wants to merge 3 commits into
Open
Add real_ps_util_renames to real_process_watchdog to avoid c_pal link in UTs#583parth21999 wants to merge 3 commits into
parth21999 wants to merge 3 commits into
Conversation
… dependency real_process_watchdog calls ps_util_terminate_process via LogCriticalAndTerminate. By adding real_ps_util_renames.h, this becomes real_ps_util_terminate_process which is provided by c_pal_reals (already linked in UTs). This eliminates the need for downstream repos to link c_pal in unit tests solely for watchdog support. Also fixes gballoc_ll_passthrough_ut PCH include order (umock_c.h must come before timed_test_suite.h for proper rename activation). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
parth21999
force-pushed
the
paaggarwal/remove-cpal-from-ut-libs
branch
from
623941f to
0a8e67c
Compare
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anporumb
reviewed
Jun 6, 2026
anporumb
reviewed
Jun 6, 2026
parth21999
force-pushed
the
paaggarwal/remove-cpal-from-ut-libs
branch
from
d7fac2f to
1cbc055
Compare
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
… link libs - Remove umock_c.h from srw_lock_int and srw_lock_ll_int (not used) - Remove real_process_watchdog and c_pal_reals from srw_lock_int/ll CMakeLists - Restore threadpool_int CMakeLists to original libs (c_pal_reals pre-existing) - Move timed_test_suite.h before umock_c.h in threadpool_int to avoid renames Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
parth21999
force-pushed
the
paaggarwal/remove-cpal-from-ut-libs
branch
from
1cbc055 to
d7a7edd
Compare
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
real_process_watchdogself-contained by addingreal_ps_util_renames.hto its compilation. Previously,real_process_watchdogcalledps_util_terminate_process(viaLogCriticalAndTerminate), requiring downstream UTs to linkc_pal. Nowps_util_terminate_processis renamed toreal_ps_util_terminate_process, which is provided byc_pal_reals(already linked in all UTs).Changes:
win32/reals/real_process_watchdog.c+linux/linux_reals/real_process_watchdog.c: Add#include "real_ps_util_renames.h"srw_lock_int,srw_lock_ll_int,threadpool_int): Changec_pal_ll_realstoc_pal_realsto providereal_ps_util_terminate_processgballoc_ll_passthrough_utPCH: Addumock_c.hbeforetimed_test_suite.hfor proper rename activationThis enables downstream repos (c-util, etc.) to avoid linking
c_palin unit tests solely for watchdog support.