Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with types for usePropsFor #5723

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

vhuseinova-msft
Copy link
Member

@vhuseinova-msft vhuseinova-msft commented Mar 20, 2025

What

With the previous implementation Typescript couldn't correctly infer the return type of the useCallingPropsFor and useChatPropsFor hooks. Change the return type to fix the issue

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401048
  • Base size: 12401048
  • Diff size: 0

Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401036
  • Base size: 12401036
  • Diff size: 0

Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 1775227
  • Base size: 1775227
  • Diff size: 0

Copy link
Contributor

Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58477 / 94462
61.9%
58477 / 94462
61.9%
1180 / 2698
43.73%
3570 / 5851
61.01%
Current 58486 / 94462
61.91%
58486 / 94462
61.91%
1180 / 2698
43.73%
3551 / 5848
60.72%
Diff 9 / 0
0.01%
9 / 0
0.01%
0 / 0
0%
-19 / -3
-0.29%

Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 29303 / 45995
63.7%
29303 / 45995
63.7%
808 / 1476
54.74%
2401 / 3819
62.86%
Current 29299 / 45995
63.7%
29299 / 45995
63.7%
808 / 1476
54.74%
2412 / 3824
63.07%
Diff -4 / 0
0%
-4 / 0
0%
0 / 0
0%
11 / 5
0.21%

@vhuseinova-msft vhuseinova-msft merged commit 03759ec into main Mar 20, 2025
57 checks passed
@vhuseinova-msft vhuseinova-msft deleted the vhuseinova/breaking-change-check-fix branch March 20, 2025 20:25
@vhuseinova-msft vhuseinova-msft restored the vhuseinova/breaking-change-check-fix branch March 20, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants