Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "specific usePropsFor to treeshake out unncessary calling/chat code" #5728

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Revert "specific usePropsFor to treeshake out unncessary calling/chat code" #5728

merged 1 commit into from
Mar 20, 2025
+6 −103

Conversation

vhuseinova-msft
Copy link
Member

Reverts #5684

@vhuseinova-msft vhuseinova-msft requested review from a team as code owners March 20, 2025 23:34
@vhuseinova-msft vhuseinova-msft added breaking-change does not need changelog Changes that does not affect the published package in any way do not need changelog entry labels Mar 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401048
  • Base size: 12401048
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401036
  • Base size: 12401036
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 1775228
  • Base size: 1775228
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-jqesfvngec.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 29294 / 45995
63.68%		 29294 / 45995
63.68%		 808 / 1476
54.74%		 2378 / 3808
62.44%
Current 29299 / 45995
63.7%		 29299 / 45995
63.7%		 808 / 1476
54.74%		 2404 / 3820
62.93%
Diff 5 / 0
0.02%		 5 / 0
0.02%		 0 / 0
0%		 26 / 12
0.49%

@github-actions GitHub Actions
Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58428 / 94462
61.85%		 58428 / 94462
61.85%		 1180 / 2698
43.73%		 3552 / 5839
60.83%
Current 58470 / 94462
61.89%		 58470 / 94462
61.89%		 1180 / 2698
43.73%		 3530 / 5827
60.58%
Diff 42 / 0
0.04%		 42 / 0
0.04%		 0 / 0
0%		 -22 / -12
-0.25%

@vhuseinova-msft vhuseinova-msft merged commit db756c3 into main Mar 20, 2025
54 of 78 checks passed
@vhuseinova-msft vhuseinova-msft deleted the revert-5684-alkwa/create-modality-specific-selectors branch March 20, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@Mohtasim Mohtasim Mohtasim approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees
No one assigned
Labels
breaking-change does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vhuseinova-msft @dmceachernmsft @Mohtasim