Hot Chocolate 15 Migration #2348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelstaib
commented
Aug 23, 2024
michaelstaib
commented
Aug 23, 2024
michaelstaib
commented
Aug 23, 2024
michaelstaib
commented
Aug 23, 2024
michaelstaib
commented
Aug 23, 2024
Collaborator
Author
|
@Aniruddh25, I will probably complete it this with whom shall I go through changes and questions? |
michaelstaib
commented
Dec 17, 2024
michaelstaib
commented
Dec 17, 2024
michaelstaib
commented
Dec 17, 2024
michaelstaib
commented
Dec 17, 2024
michaelstaib
commented
Dec 17, 2024
michaelstaib
commented
Dec 17, 2024
src/Service.Tests/Unittests/SerializationDeserializationTests.cs
Outdated
Show resolved
Hide resolved
michaelstaib
commented
Dec 17, 2024
michaelstaib
commented
Dec 17, 2024
michaelstaib
requested review from
Aniruddh25,
RubenCerna2079,
aaronburtle and
abhishekkumams
as code owners
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
vadeveka
approved these changes
May 17, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
approved these changes
May 19, 2025
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
LGTM, Thank you for this important upgrade!
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
1 task
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
RubenCerna2079
approved these changes
May 20, 2025
Collaborator
Author
|
Just as input for the docs regarding the dateTime switch: the DateTime type follows the specification for the GraphQL DateTime scalar: https://www.graphql-scalars.com/date-time/ In previous versions, we allowed more date and time formats, including formats where the timezone was omitted. This could lead to data correctness issues, as consumers of the API might interpret the time differently than you intended. The specification is very precise about the required format and how a DateTime string must be provided. Take a look at the Test Cases section of the spec. With format checking enabled, we enforce compliance with the specified format. |
RubenCerna2079
pushed a commit
that referenced
this pull request
May 29, 2025
With Hot Chocolate 15 we have invested a lot into security, performance and GraphQL protocol standards. This PR will modernize the GraphQL stack of dab. - [X] Existing Regression tests --------- Co-authored-by: Aniruddh Munde <[email protected]>
2 tasks
RubenCerna2079
pushed a commit
that referenced
this pull request
May 29, 2025
With Hot Chocolate 15 we have invested a lot into security, performance and GraphQL protocol standards. This PR will modernize the GraphQL stack of dab. - [X] Existing Regression tests --------- Co-authored-by: Aniruddh Munde <[email protected]>
RubenCerna2079
pushed a commit
that referenced
this pull request
May 29, 2025
With Hot Chocolate 15 we have invested a lot into security, performance and GraphQL protocol standards. This PR will modernize the GraphQL stack of dab. - [X] Existing Regression tests --------- Co-authored-by: Aniruddh Munde <[email protected]>
aaronburtle
added a commit
that referenced
this pull request
May 30, 2025
## Why make this change? This change is made to add the Hot-Chocolate PR to the 1.5 branch ## What is this change? This change cherry picks the PRs related to Hot-Chocolate upgrade in order to add it to the branch 1.5. - #2681 - #2348 ## How was this tested? - [ ] Integration Tests - [ ] Unit Tests ## Sample Request(s) --------- Co-authored-by: Sezal Chug <[email protected]> Co-authored-by: sezalchug <[email protected]> Co-authored-by: Tommaso Stocchi <[email protected]> Co-authored-by: Aaron Powell <[email protected]> Co-authored-by: aaronburtle <[email protected]> Co-authored-by: Aniruddh Munde <[email protected]> Co-authored-by: Jerry Nixon <[email protected]> Co-authored-by: vadeveka <[email protected]> Co-authored-by: Michael Staib <[email protected]>
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
With Hot Chocolate 15 we have invested a lot into security, performance and GraphQL protocol standards.
What is this change?
This PR will modernize the GraphQL stack of dab.
How was this tested?