winterm: remove addInRange() utility #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
Oct 3, 2020
| top := addInRange(window.Top, h.sr.top, window.Top, window.Bottom) | ||
| bottom := addInRange(window.Top, h.sr.bottom, window.Top, window.Bottom) | ||
| top := ensureInRange(window.Top+h.sr.top, window.Top, window.Bottom) | ||
| bottom := ensureInRange(window.Top+h.sr.bottom, window.Top, window.Bottom) |
Contributor
Author
There was a problem hiding this comment.
@jstarks trying to get my head around if this is correct or a bug; wondering if this should be;
Suggested change
| bottom := ensureInRange(window.Top+h.sr.bottom, window.Top, window.Bottom) | |
| bottom := ensureInRange(window.Bottom+h.sr.bottom, window.Top, window.Bottom) |
Looks like it was added in 396f10f
Collaborator
There was a problem hiding this comment.
No, I believe it's correct as-is. The effective scroll region is relative to the window rectangle, so adding to the window top is the right thing.
Of course I wrote this code 5 years ago so who knows ;)
It was only used in a single place, and a thin wrapper for ensureInRange(). Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_addInRange
branch
from
de1cfac to
c774e9b
Compare
Contributor
Author
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only used in a single place, and a thin wrapper for ensureInRange().