Updated logic for HA DB/SCS cluster configuration validation

[devanshjainms]

This pull request introduces significant refactoring and new validation logic to the HA cluster configuration validation codebase. The main focus is shifting from a parsing-first approach to a "constants-first" validation strategy, ensuring that all expected parameters from the constants are validated against the cluster information base (CIB), with improved support for offline validation. Additionally, parameter handling is enhanced to consistently track required status and expected values, and the overall status calculation now accounts for warnings as well as errors.

Validation and Parameter Handling Improvements:

• Introduced a "constants-first" validation workflow via the new validate_from_constants method in get_pcmk_properties.py, replacing the previous parsing orchestration in parse_ha_cluster_config. This ensures all expected parameters defined in constants are checked, and supports offline validation. (src/module_utils/get_pcmk_properties.py, src/module_utils/get_pcmk_properties.pyL479-R490)
• Added helper methods _validate_basic_constants, _find_param_with_element_info, _validate_resource_constants, and _validate_constraint_constants to systematically validate parameters from constants and CIB XML, including constraints and resources. (src/module_utils/get_pcmk_properties.py, src/module_utils/get_pcmk_properties.pyL538-R669)
• Updated parameter creation and expected value retrieval logic to consistently use a tuple (value, required) format, improving handling of required parameters and complex expected value types. (src/module_utils/get_pcmk_properties.py, [1] [2] [3] [4] [5]

Status Calculation and Reporting:

• Enhanced overall status calculation to distinguish between errors, warnings, and success when reporting validation results, providing more granular feedback. (src/module_utils/get_pcmk_properties.py, src/module_utils/get_pcmk_properties.pyL538-R669)

Codebase and API Changes:

• Removed legacy parsing methods (_parse_basic_config, _parse_constraints) and updated entry points in get_pcmk_properties_db.py to use the new validation method. Also adjusted resource category exclusions for improved flexibility in resource parsing. (src/module_utils/get_pcmk_properties.py, [1] [2]; src/modules/get_pcmk_properties_db.py, [3] [4]
• Minor type annotation and import cleanups for consistency. (src/module_utils/sap_automation_qa.py, [1]; src/modules/get_pcmk_properties_db.py, [2]

[Copilot]

Pull Request Overview

This PR introduces significant refactoring to the HA cluster configuration validation codebase, shifting from a parsing-first to a "constants-first" validation strategy. The main changes ensure all expected parameters from constants are validated against the cluster information base (CIB), with improved support for offline validation and enhanced parameter handling with required status tracking.

• Introduced a new validate_from_constants method replacing parse_ha_cluster_config for constants-first validation
• Enhanced parameter handling to use tuple (value, required) format for better tracking of required parameters
• Improved status calculation to distinguish between errors, warnings, and success for more granular feedback

Reviewed Changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/module_utils/get_pcmk_properties.py	Core refactoring with new validation methods and parameter handling logic
src/modules/get_pcmk_properties_*.py	Updated entry points to use new validation method
src/roles/*/constants.yaml	Updated constants structure to include value and required fields
tests/	Updated test assertions to match new tuple return format
src/vars/input-api.yaml	Enabled previously disabled test groups

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[hdamecharla]

Approved