Limit pre-validation retries, add CLI improvements and Docker log dir

[devanshjainms]

Summary

Multiple small improvements: pre-validation retry limits, CLI enhancements, and Docker log directory setup.

Changes

Pre-validation retries (DB HA & SCS HA)

• pre-validations-db.yml: Changed retries from {{ default_retries }} (75) to hardcoded 2
• pre-validations-scs.yml: Added until, retries: 2, and delay to cluster status check (previously had no retry logic)

CLI improvements (sap_automation_qa.sh)

• Added ANSIBLE_CHECK_MODE support — when set to true, passes --syntax-check to ansible-playbook
• Auto-override TEST_TYPE to SAPFunctionalTests when --test_groups is specified (prevents misconfiguration)

Docker (Dockerfile)

• Create /app/data/logs/service directory with proper ownership for service log storage

Testing

• All 748 unit tests pass with 85.23% coverage (above 85% threshold)

[Copilot]

Pull request overview

This PR makes small operational and UX improvements across the HA Ansible roles, the CLI wrapper script, and the container image—primarily to reduce long pre-validation waits, improve CLI ergonomics, and ensure a service log directory exists in Docker.

Changes:

• Limit/introduce retry behavior for SCS/DB pre-validation cluster status checks.
• Add CLI behavior: optional Ansible syntax-check mode and auto-adjust TEST_TYPE when --test_groups is used.
• Ensure /app/data/logs/service exists in the Docker image with correct ownership.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/roles/misc/tasks/pre-validations-scs.yml	Adds until/retries/delay to SCS cluster status pre-validation.
src/roles/misc/tasks/pre-validations-db.yml	Reduces DB HA cluster status pre-validation retries from configurable default to a hardcoded value.
scripts/sap_automation_qa.sh	Adds env-driven Ansible syntax-check mode and auto-overrides TEST_TYPE when filtering by test groups.
deploy/Dockerfile	Creates a persistent service log directory under /app/data/logs/service with app user ownership.

[Copilot]

retries: 2 hardcodes the pre-validation wait window and bypasses the existing default_retries configuration (defined in src/vars/input-api.yaml). This can make SCS pre-validations flaky on slower clusters and removes the ability to tune retries per environment. Consider introducing a dedicated variable (e.g., pre_validation_retries defaulting to 2) and using that here so the limit is still configurable when needed.

Suggested change

	retries: 2
	retries: "{{ pre_validation_retries | default(2) }}"

[Copilot]

Changing cluster pre-validation from retries: {{ default_retries }} (75 by default) to retries: 2 significantly reduces the time allowed for the cluster to reach a stable state and removes configurability that other HA tasks still rely on. To keep the new shorter default without risking unnecessary test skips, consider using a separate variable (default 2) that can be overridden in input config when environments need longer stabilization.

Suggested change

	retries: 2
	retries: "{{ pre_validation_cluster_status_retries | default(2) }}"

[Copilot]

The new ANSIBLE_CHECK_MODE switch enables --syntax-check, which is different from Ansible's actual “check mode” (--check). The env var name is likely to mislead users into thinking this runs a dry-run against hosts. Consider renaming the flag to something like ANSIBLE_SYNTAX_CHECK (or, if the intent really is check mode, pass --check instead of --syntax-check).

Suggested change

	if [[ "${ANSIBLE_CHECK_MODE:-}" == "true" ]]; then
	command+=" --syntax-check"
	if [[ "${ANSIBLE_SYNTAX_CHECK:-}" == "true" ]]; then
	command+=" --syntax-check"
	log "INFO" "Syntax-check mode enabled (ANSIBLE_SYNTAX_CHECK=true)"
	elif [[ "${ANSIBLE_CHECK_MODE:-}" == "true" ]]; then
	command+=" --syntax-check"
	log "WARNING" \
	"ANSIBLE_CHECK_MODE is deprecated for syntax validation; use " \
	"ANSIBLE_SYNTAX_CHECK=true instead"