Change the supported version from >= 3.4.0 to >= 3.5.0
#34
Conversation
| .stream() | ||
| .map(CONVERTER::convert) | ||
| .filter(Objects::nonNull) | ||
| .filter(s -> s.getSpringBootVersion().matches("3\\.[4-9]\\.\\d+")) // Only consider 3.4.x versions or above |
There was a problem hiding this comment.
Fix a bug when handle version like 3.5.12
There was a problem hiding this comment.
Pull request overview
This pull request updates the minimum supported Spring Boot version from 3.4.0 to 3.5.0 in the Azure Spring Cloud support tooling. The change improves the implementation by replacing a regex-based version filter with a proper semantic version comparison using the existing Version class.
Key Changes
- Replaced regex pattern
"3\\.[4-9]\\.\\d+"with a newisVersionSupported()method using proper semantic version comparison - Fixed a limitation in the old regex that would have incorrectly excluded version 4.0.0 and higher
- Added comprehensive unit tests covering boundary conditions for the new version filtering logic
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/main/java/com/azure/spring/dev/tools/actions/UpdateSpringCloudAzureSupportFileRunner.java |
Adds isVersionSupported() method with proper semantic version comparison and replaces inline regex filter |
src/test/java/com/azure/spring/dev/tools/actions/UpdateSpringCloudAzureSupportFileRunnerTest.java |
Adds comprehensive test coverage for the new version support check method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| */ | ||
| boolean isVersionSupported(String springBootVersion) { | ||
| Version version = Version.parse(springBootVersion); | ||
| Version minVersion = Version.parse("3.5.0"); |
There was a problem hiding this comment.
The minimum version "3.5.0" is parsed on every call to isVersionSupported(). Consider extracting this as a constant field (e.g., private static final Version MIN_SUPPORTED_VERSION = Version.parse("3.5.0");) to avoid redundant parsing when this method is called multiple times in stream operations.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
There was a problem hiding this comment.
Resolve this conversation because:
- It will not cause any big problem, so ignore this problem.
- The Copilot can't create another PR. See this comment: Fix TokenCredential bean name resolution in Spring Cloud Stream Binder and EventHubs Messaging azure-sdk-for-java#47444 (comment)
2 participants
Change the supported version from
>= 3.4.0to >=3.5.0