Add Scale Testing Pipeline for Cilium L7 & Kubernetes Network Policies #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date related references in configuration files
…edundant parameters
…pdating argument flags to be optional
…er2 function by removing unused parameters for improved clarity
…yml for improved command visibility
…hon script file reference
…s for consistency
…updating cloud_info parameter for consistency
MikeZappa87
reviewed
Mar 9, 2025
modules/python/clusterloader2/netpol-scale/config/modules/cilium-envoy-measurments.yaml
Outdated
Show resolved
Hide resolved
…sterloader image comment in netpol-scale-testing.yml
… collect.yml to use variable for cloud_info
…um-envoy-measurments.yaml measurments typo in the file name, fixed and pushed new file.
sanamsarath
requested review from
jshr-w,
alyssa1303,
anson627,
sumanthreddy29 and
rafael-mendes-pereira
as code owners
…hours to every 8 hours
MikeZappa87
reviewed
Mar 12, 2025
| @@ -10,6 +10,8 @@ Repository Bloat Risks | |||
| *.gz | |||
| bin/ | |||
| debug/ | |||
| venv/ | |||
| .gitignore | |||
There was a problem hiding this comment.
I don't think we want the gitignore in this file
MikeZappa87
reviewed
Mar 12, 2025
| displayName: "Every 8 hours" | ||
| branches: | ||
| include: | ||
| - sarathsa/cilium-l7-scale |
MikeZappa87
reviewed
Mar 12, 2025
| - $(LOCATION) | ||
| engine: clusterloader2 | ||
| engine_input: | ||
| image: "ghcr.io/sanamsarath/clusterloader2:vtest" # TODO: Fix this after perf-tests PR is merged |
| # TODO: Remove aks once CL2 update provider name to be azure | ||
|
|
||
|
|
||
| def configure_clusterloader2( |
There was a problem hiding this comment.
Please, add unit tests for all these new methods
Comment on lines
+15
to
+16
| DAEMONSETS_PER_NODE = {"aws": 2, "azure": 6, "aks": 6} | ||
| CPU_CAPACITY = {"aws": 0.94, "azure": 0.87, "aks": 0.87} |
There was a problem hiding this comment.
You could import it from
telescope/modules/python/clusterloader2/slo/slo.py
Lines 14 to 23 in ea4f9d5
Comment on lines
+52
to
+59
| # test config | ||
| # add "s" at the end of test_duration_secs | ||
| file.write("# Test config\n") | ||
| test_duration = str(test_duration_secs) + "s" | ||
| # Test config | ||
| # add "s" at the end of test_duration_secs | ||
| file.write("# Test config\n") | ||
| test_duration = f"{test_duration_secs}s" |
| file.close() | ||
|
|
||
|
|
||
| def validate_clusterloader2(node_count=2, operation_timeout_in_minutes=10): |
There was a problem hiding this comment.
| ) | ||
|
|
||
|
|
||
| def execute_clusterloader2( |
There was a problem hiding this comment.
| content = "" | ||
| for f in os.listdir(cl2_report_dir): | ||
| file_path = os.path.join(cl2_report_dir, f) | ||
| with open(file_path, "r", encoding="utf-8") as file: |
There was a problem hiding this comment.
Add a try/except, so it can continue reading the other files if some of them fails
| help="Number of workers per client", | ||
| ) | ||
| parser_configure.add_argument( | ||
| "--netpol_type", type=str, required=True, help="Type of network policy" |
There was a problem hiding this comment.
Could add the valid options
Comment on lines
+18
to
+21
| - script: | | ||
| run_id=$(Build.BuildId)-$(System.JobId) | ||
| echo "Run ID: $run_id" | ||
| echo "##vso[task.setvariable variable=RUN_ID]$run_id" |
There was a problem hiding this comment.
This is not required as the run id is already set here
Comment on lines
+29
to
+31
| matrix: | ||
| azure_cilium: | ||
| cl2_config_file: netpol-scale-config.yaml |
There was a problem hiding this comment.
What about the other parameters? Example:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request establishes a new pipeline for scale testing Cilium L7 network policies, and Kubernetes network policies. It also supports configuration to run feature, soak, and load tests. Currently, it handles network policies matching HTTP traffic, with plans to extend support for benchmarking and scale testing other L4 and L7 network policies.
[Copilot generated Summary]
This pull request introduces several new configurations and functionalities for Cilium and network policy scale testing in the
clusterloader2framework. The changes include adding new measurement modules, updating configuration files, and enhancing the main script to support these new features.Key changes include:
New Measurement Modules:
cilium-envoy-measurments.yamlto collect various Cilium Envoy HTTP and memory metrics using Prometheus queries.cilium-measurements.yamlto gather additional Cilium metrics such as queueing delay, CPU usage, and memory usage using Prometheus queries.Configuration Updates:
netpol-scale-config.yamlto include parameters for enabling Cilium and Cilium Envoy, and to define the steps for starting and gathering measurements.Script Enhancements:
netpol_scale.pyto include functions for configuring, validating, executing, and collecting results fromclusterloader2tests. The script now supports command-line arguments for various test parameters and configurations.Pipeline Configuration:
netpol-scale-testing.ymlto define the CI/CD pipeline for network policy scale testing usingclusterloader2.