Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to scrape containerd metrics #557

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

alyssa1303
Copy link
Collaborator

@alyssa1303 alyssa1303 commented Mar 6, 2025

Summary

  • Add option to scrape containerd metrics for network setup with newer CL2 image
  • Split AWS node group into smaller ones to help with throttling
  • Add user data to enable containerd metrics on AWS
  • Remove unused arguments and re-enabled linter for collect function

@alyssa1303 alyssa1303 force-pushed the alyssa/scrape-containerd branch from e91ddbf to b0f0ce9 Compare March 6, 2025 21:39
@alyssa1303 alyssa1303 force-pushed the alyssa/scrape-containerd branch from b0f0ce9 to 688b6a0 Compare March 7, 2025 21:00
@alyssa1303 alyssa1303 force-pushed the alyssa/scrape-containerd branch from 9eab2e8 to fa0c01e Compare March 7, 2025 21:57
@alyssa1303 alyssa1303 force-pushed the alyssa/scrape-containerd branch from fa0c01e to 38ca17b Compare March 7, 2025 22:31
@alyssa1303 alyssa1303 force-pushed the alyssa/scrape-containerd branch 2 times, most recently from 6c31210 to d4ce3ad Compare March 11, 2025 17:05
@alyssa1303 alyssa1303 force-pushed the alyssa/scrape-containerd branch 3 times, most recently from d15ff76 to 630a896 Compare March 11, 2025 19:17
@alyssa1303 alyssa1303 marked this pull request as ready for review March 11, 2025 19:50
@alyssa1303 alyssa1303 force-pushed the alyssa/scrape-containerd branch from 630a896 to 59f0e7d Compare March 11, 2025 20:31
unit: s
queries:
- name: Perc99
query: histogram_quantile(0.99, sum(rate(containerd_cri_sandbox_runtime_create_seconds_bucket{nodepool=~"userpool.*"}[%v])) by (le))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

containerd_cri_sandbox_create_network_seconds_bucket and containerd_cri_sandbox_delete_network_seconds_bucket should be good for now

Copy link
Collaborator Author

@alyssa1303 alyssa1303 Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep "containerd_cri_network_plugin_operations_duration_seconds_seconds_bucket" since it's directly related to CNI?

@alyssa1303 alyssa1303 requested a review from anson627 March 11, 2025 21:43
@alyssa1303 alyssa1303 force-pushed the alyssa/scrape-containerd branch from d44aadb to 42a7e3a Compare March 12, 2025 00:22
@alyssa1303 alyssa1303 force-pushed the alyssa/scrape-containerd branch from 42a7e3a to 95bf982 Compare March 12, 2025 03:46
@alyssa1303 alyssa1303 force-pushed the alyssa/scrape-containerd branch from 337b656 to ecb4f68 Compare March 12, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants