Add node_pools to outputs

[SubatomicHero]

Describe your changes

This change adds the node_pools created with var.node_pools to the outputs. Useful for local testing of the module

Checklist before requesting a review

• The pr title can be used to describe what this pr did in CHANGELOG.md file
• I have executed pre-commit on my machine
• I have passed pr-check on my machine

[zioproto]

Hello @SubatomicHero ,
could you please make an example of why we need this PR ?
can you do a practical example of something you are testing that requires this output ?
thanks

[lonegunmanb]

Thanks @SubatomicHero for opening this pr! We don't encourage outputting resource directly in the module, I've checked data.azurerm_kubernetes_cluster_node_pool and all it requires is cluster name, pool name and resource group name.

Could we only output the pools' names like this?:

output "pool_name" {
  value = { for k, p in azurerm_kubernetes_cluster_node_pool.node_pool : k => p.name }
}

[fleetwoodstack]

@lonegunmanb sorry for the late reply. That's been done and I agree with your change! This is now ready to review again

@zioproto the use case is so that we can run our terraform test assertions making sure the extra node pool is configured a certain way. We need access to the azurerm_kubernetes_cluster_node_pool.node_pool output to allow this.

[fleetwoodstack]

@zioproto is there anything else this PR is waiting on to progress?

I've taken over since the PR owner has since left our organisation so won't be contributing to it.

[zioproto]

@fleetwoodstack LGTM. I don't have ownership over this repo to merge the PR. Friendly ping to @lonegunmanb to approve the CI workflow and eventually merge :) Thanks

[fleetwoodstack]

@lonegunmanb are you OK to mark your requested changes as having been done? I don't own this PR sadly to be able to mark them as completed.

[fleetwoodstack]

@lonegunmanb When you get a moment, this is ready to merge

[fleetwoodstack]

@lonegunmanb Can you please merge this?

[fleetwoodstack]

@lonegunmanb please can you mark your requested changes as having been done? This PR is nearly 2 years old