appgw_rule01 fix for destination_address_prefixes#32
Open
ckellywilson wants to merge 9 commits intoAzure:mainfrom
Open
appgw_rule01 fix for destination_address_prefixes#32ckellywilson wants to merge 9 commits intoAzure:mainfrom
ckellywilson wants to merge 9 commits intoAzure:mainfrom
Conversation
- Update terraform.languageServer.terraform.path from incorrect /home/runtimeuser/tfenv/bin/terraform to correct /usr/bin/terraform - Fixes devcontainer startup error where terraform binary was not found - Terraform v1.12.2 is available at /usr/bin/terraform in the mcr.microsoft.com/azterraform:avm-latest container
- Add Docker-in-Docker feature for container builds - Add Azure Developer CLI (azd) feature - Add ms-azuretools.azure-dev extension for Azure development - Maintain correct terraform binary path at /usr/bin/terraform - Remove duplicate extensions and fix JSON structure
- Update devcontainer to use Ubuntu base with comprehensive tooling - Add Azure MCP server integration for enhanced Azure operations - Configure advanced GitHub Copilot Chat features (math, todo, thinking tool) - Add Dependabot configuration for automated dev container updates - Backup original devcontainer configuration - Enable MCP server sampling for live Azure resource management This update modernizes the development environment with: - Latest Terraform, Azure CLI, Node.js, PowerShell support - Enhanced AI assistance capabilities through MCP integration - Automated dependency management via Dependabot - Improved developer experience with extended chat features
- Switch from Ubuntu base container to mcr.microsoft.com/azterraform:avm-latest - Configure container environment for AVM development - Update Terraform language server path to /usr/bin/terraform - Add azapi-vscode extension for Azure API support - Remove old devcontainer.json.old backup file - Optimize container setup for Azure Verified Modules development
…s_prefix='GatewayManager
Updates appgw_rule01 destination_address_prefixes from specific subnet addresses to '*' to comply with Azure Application Gateway requirements. This ensures proper management plane connectivity for Application Gateway infrastructure operations. Reference: https://learn.microsoft.com/en-us/azure/application-gateway/configuration-infrastructure#network-security-groups
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
Change from destination_address_prefixes to destination_address_prefix for single value '*' to match Terraform azurerm provider syntax.
Contributor
Author
|
Hi @mbilalamjad, This PR has been open for a while without activity. Could someone please review or provide an update on its status? If additional information or changes are needed, please let me know. Thank you for your time and support! /cc @maintainers |
MinHeinA
added a commit
to MinHeinA/terraform-azurerm-avm-ptn-aiml-landing-zone
that referenced
this pull request
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #35
Technical Issue Fixed:
The Application Gateway NSG management rule was using incorrect Terraform azurerm provider syntax:
destination_address_prefixes = "*"(incorrect - expects array)destination_address_prefix = "*"(correct - single string value)Root Cause:
The
destination_address_prefixesproperty expects an array of strings["*"], but when using a single wildcard value"*", the correct property isdestination_address_prefix(singular).Microsoft Compliance:
The Application Gateway rule for the source GatewayManager specifies that the destination should be "*" for Any address. This fix brings the rule into compliance with both Microsoft documented configuration AND correct Terraform azurerm provider syntax.
Impact:
Validation