Add existing private dns linking for vnet#61
Open
ChrisChapman-gh wants to merge 2 commits intoAzure:mainfrom
Open
Add existing private dns linking for vnet#61ChrisChapman-gh wants to merge 2 commits intoAzure:mainfrom
ChrisChapman-gh wants to merge 2 commits intoAzure:mainfrom
Conversation
2d11761 to
93f655a
Compare
MinHeinA
added a commit
to MinHeinA/terraform-azurerm-avm-ptn-aiml-landing-zone
that referenced
this pull request
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #60
Depends on #50
Adds linking between the created vnet and existing private dns zones.
Moves the platform + created/existing zone resource Id logic to the locals.
Removed the need for a dummy value should created/existing not be required. Either the private endpoints are managing the
dns zone group, in which case an existing or created id should be present, or they are unmanaged and a null/[] is passed and ignored.
Type of Change
Checklist