Skip to content

refactor: update app gateway WAF policy module and resource ID handling #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisChapman-gh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: update app gateway WAF policy module and resource ID handling #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion main.networking.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,15 @@ module "private_dns_zones" {
depends_on = [module.hub_vnet_peering]
}

moved {
from = module.app_gateway_waf_policy
to = module.app_gateway_waf_policy[0]
}

module "app_gateway_waf_policy" {
source = "Azure/avm-res-network-applicationgatewaywebapplicationfirewallpolicy/azurerm"
version = "0.2.0"
count = var.app_gateway_definition.deploy ? 1 : 0

location = azurerm_resource_group.this.location
managed_rules = var.waf_policy_definition.managed_rules #local.web_application_firewall_managed_rules
Expand All @@ -240,7 +246,7 @@ module "application_gateway" {
name = local.application_gateway_name
request_routing_rules = var.app_gateway_definition.request_routing_rules
resource_group_name = azurerm_resource_group.this.name
app_gateway_waf_policy_resource_id = module.app_gateway_waf_policy.resource_id
app_gateway_waf_policy_resource_id = one(module.app_gateway_waf_policy[*].resource_id)
authentication_certificate = var.app_gateway_definition.authentication_certificate
autoscale_configuration = var.app_gateway_definition.autoscale_configuration
diagnostic_settings = {
Expand Down