feat: use compact for prefix and suffix variables in locals#213
Open
bonddim wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves Terraform name generation in main.tf by ensuring any empty elements in var.prefix and var.suffix are removed before constructing derived local values, preventing accidental empty segments and stray dashes in generated resource names.
Changes:
- Apply
compact()tovar.prefixwhen computinglocal.prefixandlocal.prefix_safe. - Apply
compact()tovar.suffixwhen computinglocal.suffix,local.suffix_safe, and the*_unique*variants that appendlocal.random.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important improvement to how prefixes and suffixes are handled in the
main.tfTerraform configuration. The main change ensures that any empty values in thevar.prefixandvar.suffixlists are removed before being joined, which helps prevent unwanted dashes or empty segments in generated names.var.prefixandvar.suffixin local variables to use thecompact()function, which removes empty values before joining. This results in cleaner, more predictable resource names and avoids issues caused by empty list elements.