Update the client generation document to provide valid typespec samples #2237
+15
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lirenhe
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- website/src/content/docs/docs/howtos/Generate client libraries/06types.mdx: Language not supported
- website/src/content/docs/docs/howtos/Generate client libraries/08methodInputs.mdx: Language not supported
|
No changes needing a change description found. |
|
You can try these changes here
|
markcowl
added
the
lib:tcgc
tadelesh
reviewed
Mar 11, 2025
Comment on lines
-706
to
-713
| ```typespec | ||
| model Animal { | ||
| name: string; | ||
| kind: string; | ||
| ...Record<string | int32>; | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
if we do not support union type, we could also remove this section.
|
|
||
| model Ragdoll {} | ||
| ``` | ||
|
|
||
| </ClientTabItem> | ||
| <ClientTabItem lang="tcgc"> | ||
|
|
There was a problem hiding this comment.
the next line could be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the below 2 documents to validate all existing typespec samples