Skip to content

Fix x-ms-identifier present on every array model #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix x-ms-identifier present on every array model #2607

wants to merge 10 commits into from

Conversation

AlitzelMendez
Copy link
Member

@AlitzelMendez AlitzelMendez commented Apr 30, 2025 •
edited
Loading

issue: #2323

@AlitzelMendez AlitzelMendez changed the title Fix identifiers every array Fix x-ms-identifier present on every array model Apr 30, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 30, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-autorest
Show changes

@azure-tools/typespec-autorest - fix ✏️

Fix x-ms-identifiers being automatically populated, which caused default values to be overwritten unexpectedly. Now, it is only set when explicitly defined.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 30, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website

@AlitzelMendez AlitzelMendez marked this pull request as ready for review May 6, 2025 15:26
@AlitzelMendez AlitzelMendez linked an issue May 6, 2025 that may be closed by this pull request
Issue with empty x-ms-identifiers getting injected for data plane specs #2323
Open
markcowl
markcowl reviewed May 13, 2025
View reviewed changes
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a candidate PR against the specs repo? Otherwise, this looks good

@AlitzelMendez
Copy link
Member Author

AlitzelMendez commented May 14, 2025 •
edited
Loading

Candidate pull requests

please not that there are changes in two swaggers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcowl markcowl markcowl left review comments

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with empty x-ms-identifiers getting injected for data plane specs
3 participants
@AlitzelMendez @azure-sdk @markcowl