Skip to content

Make request bodies optional #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 15, 2025
Merged

Conversation

markcowl
Copy link
Member

@markcowl markcowl commented May 13, 2025

Still needs:

  • Sample
  • Tests
  • azure-rest-api-specs-prs

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 13, 2025

All changed packages have been documented.

  • @azure-tools/typespec-azure-resource-manager
  • @azure-tools/typespec-azure-rulesets
Show changes

@azure-tools/typespec-azure-resource-manager - fix ✏️

Corrected the references for PrivateEndpointConnectionListResultV5 and PrivateLinkResourceListResultV5 in common-types.

@azure-tools/typespec-azure-rulesets - fix ✏️

Discourage use of legacy types outside brownfield conversions

@azure-tools/typespec-azure-resource-manager - feature ✏️

Add support for resources with multiple operation paths

@azure-tools/typespec-azure-resource-manager - feature ✏️

Allow optional request bodies in Resource actions templates

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 13, 2025

You can try these changes here

🛝 Playground 🌐 Website

@markcowl markcowl marked this pull request as ready for review May 14, 2025 00:14
@markcowl
Copy link
Member Author

markcowl commented May 14, 2025

azure-rest-api-specs: Azure/azure-rest-api-specs#34701 (note that ai failures are due to missing config, and unrelated to this)
and private: https://github.com/Azure/azure-rest-api-specs-pr/pull/22705

@AlitzelMendez
Copy link
Member

azure-rest-api-specs: Azure/azure-rest-api-specs#34701 (note that ai failures are due to missing config, and unrelated to this)

I see a related issue

Model doesn't have member body
2025-05-14T22:33:56.2610267Z > 25 | @@clientName(EndpointResources.listManagedProxyDetails::parameters.body,

in specification/hybridconnectivity/HybridConnectivity.Management

@markcowl
Copy link
Member Author

azure-rest-api-specs: Azure/azure-rest-api-specs#34701 (note that ai failures are due to missing config, and unrelated to this)

I see a related issue

Model doesn't have member body
2025-05-14T22:33:56.2610267Z > 25 | @@clientName(EndpointResources.listManagedProxyDetails::parameters.body,

in specification/hybridconnectivity/HybridConnectivity.Management

I think I got that one (in main.tsp). lmk, if I missed a different one

@AlitzelMendez
Copy link
Member

azure-rest-api-specs: Azure/azure-rest-api-specs#34701 (note that ai failures are due to missing config, and unrelated to this)

I see a related issue

Model doesn't have member body
2025-05-14T22:33:56.2610267Z > 25 | @@clientName(EndpointResources.listManagedProxyDetails::parameters.body,

in specification/hybridconnectivity/HybridConnectivity.Management

I think I got that one (in main.tsp). lmk, if I missed a different one

I think the one missing is here: tsp compile --no-emit --warn-as-error /home/runner/work/azure-rest-api-specs/azure-rest-api-specs/specification/hybridconnectivity/HybridConnectivity.Management/client.tsp and tsp compile --no-emit --warn-as-error /home/runner/work/azure-rest-api-specs/azure-rest-api-specs/specification/loadtestservice/LoadTestService.Management/client.tsp

@markcowl markcowl merged commit 0f5ca05 into Azure:release/may-2025 May 15, 2025
22 checks passed
markcowl added a commit to markcowl/typespec-azure that referenced this pull request May 17, 2025
Still needs:

- [x] Sample
- [x] Tests
- [x] azure-rest-api-specs-prs

---------

Co-authored-by: Timothee Guerin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants