[typespec-ts] fix platform import issue for customization by kazrael2119 · Pull Request #4585 · Azure/typespec-azure

kazrael2119 · 2026-06-09T07:19:29Z

fixes #4581

azure-sdk · 2026-06-09T07:20:54Z

All changed packages have been documented.

✅ @azure-tools/typespec-ts

Show changes

`@azure-tools/typespec-ts` - fix ✏️

[typespec-ts] fix platform import issue for customization

pkg-pr-new · 2026-06-09T07:22:21Z

Open in StackBlitz

npm i https://pkg.pr.new/@azure-tools/typespec-ts@4585

commit: e5674c5

github-actions · 2026-06-09T07:28:47Z

⚡ Benchmark Results

⚠️ 2 metric(s) regressed above the +5% threshold:

Metric	Baseline	Current	Change
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-delete-operation-response-codes	🟢 5.4ms	🟡 12.6ms	+130.9% 🔴
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes	🟢 1.4ms	🟢 3.3ms	+140.4% 🔴

Full details – comparing bbcc784 vs baseline rolling-baseline-aac448e-4df8556 (rolling baseline (20 main runs))

Metric	Baseline	Current	Change
total	🔴 997.8ms	🔴 865.7ms	-13.2% 🟢
loader	🟡 300.5ms	🟡 261.5ms	-13.0% 🟢
resolver	🟢 39.9ms	🟢 36.1ms	-9.6% 🟢
checker	🟡 359.7ms	🟡 308.1ms	-14.4% 🟢
validation	🟢 84.9ms	🟢 74.5ms	-12.3% 🟢
↳ validation/@azure-tools/typespec-azure-core	🟡 12.4ms	🟡 10.5ms	-15.5% 🟢
↳ validation/@typespec/http	🟡 15.3ms	🟡 13.4ms	-12.5% 🟢
↳ validation/@typespec/rest	🟢 1.6ms	🟢 1.5ms	-6.6%
↳ validation/@typespec/versioning	🔴 51.5ms	🔴 45.6ms	-11.5% 🟢
↳ validation/compiler	🟢 3.8ms	🟢 3.5ms	-10.2%
linter	🟡 212.1ms	🟢 185.3ms	-12.6% 🟢
↳ linter/@azure-tools/typespec-azure-core/auth-required	🟢 0.1ms	🟢 0.1ms	-17.9%
↳ linter/@azure-tools/typespec-azure-core/bad-record-type	🟢 0.6ms	🟢 0.6ms	-7.7%
↳ linter/@azure-tools/typespec-azure-core/byos	🟢 8.2ms	🟢 7.5ms	-9.5%
↳ linter/@azure-tools/typespec-azure-core/casing-style	🟢 1.4ms	🟢 1.4ms	-3.8%
↳ linter/@azure-tools/typespec-azure-core/composition-over-inheritance	🟢 0.2ms	🟢 0.2ms	-13.3%
↳ linter/@azure-tools/typespec-azure-core/documentation-required	🟢 1.9ms	🟢 1.7ms	-10.2%
↳ linter/@azure-tools/typespec-azure-core/friendly-name	🟢 1.4ms	🟢 1.3ms	-7.7%
↳ linter/@azure-tools/typespec-azure-core/key-visibility-required	🟢 0.4ms	🟢 0.3ms	-12.5%
↳ linter/@azure-tools/typespec-azure-core/known-encoding	🟢 0.5ms	🟢 0.4ms	-10.4%
↳ linter/@azure-tools/typespec-azure-core/long-running-polling-operation-required	🟢 0.8ms	🟢 0.8ms	+0.1%
↳ linter/@azure-tools/typespec-azure-core/no-case-mismatch	🟢 0.7ms	🟢 0.6ms	-10.7%
↳ linter/@azure-tools/typespec-azure-core/no-closed-literal-union	🟢 1.0ms	🟢 0.9ms	-5.6%
↳ linter/@azure-tools/typespec-azure-core/no-enum	🟢 0.2ms	🟢 0.2ms	-7.9%
↳ linter/@azure-tools/typespec-azure-core/no-error-status-codes	🟢 0.3ms	🟢 0.3ms	-0.0%
↳ linter/@azure-tools/typespec-azure-core/no-explicit-routes-resource-ops	🟢 0.2ms	🟢 0.2ms	-1.5%
↳ linter/@azure-tools/typespec-azure-core/no-format	🟢 0.8ms	🟢 0.8ms	-2.2%
↳ linter/@azure-tools/typespec-azure-core/no-generic-numeric	🟢 0.8ms	🟢 0.7ms	-13.7%
↳ linter/@azure-tools/typespec-azure-core/no-header-explode	🔴 26.1ms	🔴 21.8ms	-16.7% 🟢
↳ linter/@azure-tools/typespec-azure-core/no-legacy-usage	🟢 2.0ms	🟢 1.9ms	-4.3%
↳ linter/@azure-tools/typespec-azure-core/no-multiple-discriminator	🟢 0.2ms	🟢 0.2ms	-16.9%
↳ linter/@azure-tools/typespec-azure-core/no-nullable	🟢 0.4ms	🟢 0.4ms	-13.1%
↳ linter/@azure-tools/typespec-azure-core/no-offsetdatetime	🟢 1.9ms	🟢 1.7ms	-14.2%
↳ linter/@azure-tools/typespec-azure-core/no-openapi	🟢 2.3ms	🟢 2.1ms	-6.8%
↳ linter/@azure-tools/typespec-azure-core/no-private-usage	🟢 3.1ms	🟢 2.9ms	-5.1%
↳ linter/@azure-tools/typespec-azure-core/no-query-explode	🔴 27.3ms	🔴 22.9ms	-15.9% 🟢
↳ linter/@azure-tools/typespec-azure-core/no-response-body	🔴 32.8ms	🔴 28.5ms	-13.0% 🟢
↳ linter/@azure-tools/typespec-azure-core/no-rest-library-interfaces	🟢 0.1ms	🟢 0.1ms	-10.7%
↳ linter/@azure-tools/typespec-azure-core/no-route-parameter-name-mismatch	🟢 7.5ms	🟢 6.4ms	-15.1% 🟢
↳ linter/@azure-tools/typespec-azure-core/no-rpc-path-params	🟢 0.4ms	🟢 0.3ms	-13.7%
↳ linter/@azure-tools/typespec-azure-core/no-string-discriminator	🟢 0.1ms	🟢 0.1ms	-17.7%
↳ linter/@azure-tools/typespec-azure-core/no-unknown	🟢 0.3ms	🟢 0.3ms	-10.4%
↳ linter/@azure-tools/typespec-azure-core/no-unnamed-union	🟢 0.8ms	🟢 0.7ms	-6.2%
↳ linter/@azure-tools/typespec-azure-core/operation-missing-api-version	🟢 0.4ms	🟢 0.4ms	+5.4%
↳ linter/@azure-tools/typespec-azure-core/request-body-problem	🟢 0.5ms	🟢 0.4ms	-6.2%
↳ linter/@azure-tools/typespec-azure-core/require-versioned	🟢 0.1ms	🟢 0.1ms	-14.2%
↳ linter/@azure-tools/typespec-azure-core/response-schema-problem	🔴 32.2ms	🔴 28.1ms	-12.6% 🟢
↳ linter/@azure-tools/typespec-azure-core/rpc-operation-request-body	🟢 0.7ms	🟢 0.6ms	-11.8%
↳ linter/@azure-tools/typespec-azure-core/spread-discriminated-model	🟢 0.5ms	🟢 0.4ms	-8.7%
↳ linter/@azure-tools/typespec-azure-core/use-standard-names	🟢 7.4ms	🟢 6.3ms	-14.8% 🟢
↳ linter/@azure-tools/typespec-azure-core/use-standard-operations	🟢 0.3ms	🟢 0.2ms	-7.3%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-agent-base-type-child-resources	🔴 21.6ms	🟡 10.9ms	-49.6% 🟢
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-agent-base-type-lifecycle-operations	🟢 0.3ms	🟢 0.2ms	-22.3%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-common-types-version	🟡 12.0ms	🟢 9.8ms	-18.9% 🟢
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-custom-resource-no-key	🟢 0.2ms	🟢 0.2ms	-15.3%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-custom-resource-usage-discourage	🟢 0.1ms	🟢 0.1ms	-14.0%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-delete-operation-response-codes	🟢 5.4ms	🟡 12.6ms	+130.9% 🔴
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-no-path-casing-conflicts	🟡 17.0ms	🟡 14.2ms	-16.4% 🟢
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-no-record	🟢 0.6ms	🟢 0.6ms	-7.1%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes	🟢 1.4ms	🟢 3.3ms	+140.4% 🔴
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-put-operation-response-codes	🟢 0.2ms	🟢 0.3ms	+16.5%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-action-no-segment	🟢 0.4ms	🟢 0.5ms	+4.2%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-duplicate-property	🟢 0.4ms	🟢 0.3ms	-12.0%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-interface-requires-decorator	🟢 0.1ms	🟢 0.1ms	-15.3%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-action-verb	🟢 0.2ms	🟢 0.2ms	+0.4%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property	🟢 0.3ms	🟢 0.2ms	-12.6%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-version-format	🟢 0.2ms	🟢 0.2ms	+1.3%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-key-invalid-chars	🟢 0.5ms	🟢 0.4ms	-13.5%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-name-pattern	🟢 0.1ms	🟢 0.2ms	+10.8%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-operation	🟢 0.5ms	🟢 0.5ms	+2.7%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-operation-response	🟢 8.8ms	🟢 7.9ms	-10.2%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-patch	🟢 0.8ms	🟢 0.8ms	-8.6%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-path-segment-invalid-chars	🟢 0.4ms	🟢 0.3ms	-11.5%
↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-provisioning-state	🟢 0.4ms	🟢 0.4ms	-4.8%
↳ linter/@azure-tools/typespec-azure-resource-manager/beyond-nesting-levels	🟢 0.2ms	🟢 0.2ms	-13.7%
↳ linter/@azure-tools/typespec-azure-resource-manager/empty-updateable-properties	🟢 0.4ms	🟢 0.3ms	-15.4%
↳ linter/@azure-tools/typespec-azure-resource-manager/improper-subscription-list-operation	🟢 0.1ms	🟢 0.1ms	-10.2%
↳ linter/@azure-tools/typespec-azure-resource-manager/lro-location-header	🟡 19.2ms	🟡 16.3ms	-15.0% 🟢
↳ linter/@azure-tools/typespec-azure-resource-manager/missing-operations-endpoint	🟢 0.1ms	🟢 0.1ms	-4.7%
↳ linter/@azure-tools/typespec-azure-resource-manager/missing-x-ms-identifiers	🟢 1.0ms	🟢 0.9ms	-8.0%
↳ linter/@azure-tools/typespec-azure-resource-manager/no-empty-model	🟢 0.3ms	🟢 0.2ms	-18.0%
↳ linter/@azure-tools/typespec-azure-resource-manager/no-override-props	🟢 0.3ms	🟢 0.3ms	-2.2%
↳ linter/@azure-tools/typespec-azure-resource-manager/no-resource-delete-operation	🟢 0.4ms	🟢 0.4ms	-17.6%
↳ linter/@azure-tools/typespec-azure-resource-manager/no-response-body	🔴 29.3ms	🔴 24.9ms	-14.9% 🟢
↳ linter/@azure-tools/typespec-azure-resource-manager/patch-envelope	🟢 0.4ms	🟢 0.4ms	-11.0%
↳ linter/@azure-tools/typespec-azure-resource-manager/resource-name	🟢 0.4ms	🟢 0.4ms	-10.7%
↳ linter/@azure-tools/typespec-azure-resource-manager/secret-prop	🟢 5.4ms	🟢 4.7ms	-13.1%
↳ linter/@azure-tools/typespec-azure-resource-manager/unsupported-type	🟢 0.7ms	🟢 0.6ms	-9.2%
↳ linter/@azure-tools/typespec-azure-resource-manager/version-progression	🟢 0.3ms	🟢 0.3ms	+3.9%
↳ linter/@azure-tools/typespec-client-generator-core/property-name-conflict	🟢 2.3ms	🟢 2.1ms	-6.2%
↳ linter/@azure-tools/typespec-client-generator-core/require-client-suffix	🟢 1.6ms	🟢 1.6ms	-2.7%
emit	🔴 5.97s	🔴 5.12s	-14.2% 🟢
↳ emit/@Azure-Tools	🟢 0.0ms	🟢 0.0ms	+0.0%
↳ emit/@azure-tools/typespec-autorest	🟢 123.8ms	🟢 109.9ms	-11.2% 🟢
↳ emit/@azure-tools/typespec-python	🔴 2.23s	🔴 1.89s	-15.0% 🟢
↳ emit/@typespec	🟢 0.0ms	🟢 0.0ms	+0.0%
↳ emit/@typespec/http-client-js	🔴 564.7ms	🔴 497.3ms	-11.9% 🟢
↳ emit/@typespec/openapi3	🟢 106.3ms	🟢 91.9ms	-13.6% 🟢
↳ emit/@typespec/openapi3/compute	🟢 92.3ms	🟢 79.7ms	-13.6% 🟢
↳ emit/@typespec/openapi3/write	🟢 13.8ms	🟢 11.9ms	-13.7% 🟢

Averaged across 3 specs (azure-arm-resource-manager, azure-core-dataplane, azure-full).
Threshold: changes > ±5% are highlighted.
🟢 Fast · 🟡 Moderate (stages >200ms, rules >10ms) · 🔴 Slow (stages >400ms, rules >20ms)

azure-sdk · 2026-06-09T07:29:33Z

You can try these changes here

🛝 Playground	🌐 Website

jeremymeng · 2026-06-09T18:23:53Z

@kazrael2119 maybe as part of this PR, we could get rid of the platform-types source files, and import from @azure/core-rest-pipeline? The type is available now in latest v1.24.0 https://github.com/Azure/azure-sdk-for-js/blob/%40azure/core-rest-pipeline_1.24.0/sdk/core/core-rest-pipeline/review/core-rest-pipeline-node.api.md?plain=1#L239

JialinHuang803 · 2026-06-11T08:50:09Z

Maybe we can remove #platform in this PR after Azure/azure-sdk-for-js#38909.

…expectations Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>

JialinHuang803 · 2026-07-07T02:37:10Z

-      });
+      expect(packageFile.dependencies).to.have.property("@azure-rest/core-client", "^2.7.0");
+      expect(packageFile.dependencies).to.have.property("@azure/core-rest-pipeline", "^1.24.0");
+      expect(packageFile.dependencies).to.have.property("tslib", "^2.8.1");


I remember that tslib is already changed to be imported from catalog. Should we change this as well?

this is a test case to test updatePackageFile with customized packageinfo, see
https://github.com/kazrael2119/typespec-azure/blob/fix-platfor-import/packages/typespec-ts/test-next/unit/metadata/package-json.test.ts#L566-L581

[typespec-ts] fix platform import issue for customization

168c199

kazrael2119 requested review from JialinHuang803, MaryGao, maorleger and qiaozha as code owners June 9, 2026 07:19

microsoft-github-policy-service Bot added the emitter:typescript Issues for @azure-tools/typespec-ts emitter label Jun 9, 2026

update

c670826

kazrael2119 requested review from bterlson, markcowl and timotheeguerin as code owners June 22, 2026 05:53

kazrael2119 added 6 commits June 25, 2026 15:18

Update pnpm-lock.yaml

525cbbe

merge main and update changes

964a0cd

update

5d8e67b

Merge branch 'main' into pr/4585

186d673

update

a0e2ef3

merge main

56bf491

JialinHuang803 reviewed Jun 26, 2026

View reviewed changes

Comment thread packages/typespec-ts/src/modular/static-helpers-metadata.ts Outdated

JialinHuang803 reviewed Jun 26, 2026

View reviewed changes

Comment thread packages/typespec-ts/src/modular/static-helpers-metadata.ts Outdated

JialinHuang803 reviewed Jun 26, 2026

View reviewed changes

Comment thread packages/typespec-ts/src/rlc-common/metadata/build-package-file.ts Outdated

kazrael2119 added 2 commits June 26, 2026 16:40

Update load-static-helpers.ts

aa89875

update

9a1800e

kazrael2119 requested a review from xirzec as a code owner June 29, 2026 08:42

kazrael2119 added 2 commits July 2, 2026 17:49

update

c56a6d6

Merge branch 'main' into pr/4585

888903c

kazrael2119 added 4 commits July 3, 2026 14:17

Update pnpm-lock.yaml

89cab6a

remove platform test case

01f9776

fix test

b1379db

update

26e7e25

Copilot AI mentioned this pull request Jul 3, 2026

[typespec-ts] Fix platform import issue for customization #4810

Closed

Copilot AI added a commit that referenced this pull request Jul 3, 2026

Fix failing CI tests: apply PR #4585 changes and update missing test …

e50d76f

…expectations Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>

kazrael2119 and others added 5 commits July 6, 2026 09:55

update test

7c9c466

format

d0f76b6

Merge branch 'main' into fix-platfor-import

92ad0b1

Update index.d.ts

6732357

Create fix-platfor-import-2026-6-6-3-14-22.md

7458858

JialinHuang803 reviewed Jul 7, 2026

View reviewed changes

Comment thread packages/typespec-ts/src/metadata/build-package-file.ts Outdated

JialinHuang803 reviewed Jul 7, 2026

View reviewed changes

Comment thread packages/typespec-ts/test-next/unit/metadata/package-json.test.ts

JialinHuang803 reviewed Jul 7, 2026

View reviewed changes

Comment thread packages/typespec-ts/test-next/unit/metadata/package-json.test.ts

kazrael2119 added 4 commits July 7, 2026 14:26

remove #platform import codes

5957a1d

revert unexpected test case changes

eda6e30

Update package-json.test.ts

e5674c5

Update package-json.test.ts

3a11040

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[typespec-ts] fix platform import issue for customization#4585

[typespec-ts] fix platform import issue for customization#4585
kazrael2119 wants to merge 25 commits into
Azure:mainfrom
kazrael2119:fix-platfor-import

kazrael2119 commented Jun 9, 2026

Uh oh!

azure-sdk commented Jun 9, 2026 •

edited by azure-sdk-automation Bot

Loading

`@azure-tools/typespec-ts` - fix ✏️

Uh oh!

pkg-pr-new Bot commented Jun 9, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 9, 2026 •

edited

Loading

Uh oh!

azure-sdk commented Jun 9, 2026

Uh oh!

jeremymeng commented Jun 9, 2026

Uh oh!

JialinHuang803 commented Jun 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JialinHuang803 Jul 7, 2026

Uh oh!

kazrael2119 Jul 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

kazrael2119 commented Jun 9, 2026

Uh oh!

azure-sdk commented Jun 9, 2026 • edited by azure-sdk-automation Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@azure-tools/typespec-ts - fix ✏️

Uh oh!

pkg-pr-new Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡ Benchmark Results

Uh oh!

azure-sdk commented Jun 9, 2026

Uh oh!

jeremymeng commented Jun 9, 2026

Uh oh!

JialinHuang803 commented Jun 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JialinHuang803 Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

kazrael2119 Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

azure-sdk commented Jun 9, 2026 •

edited by azure-sdk-automation Bot

Loading

`@azure-tools/typespec-ts` - fix ✏️

pkg-pr-new Bot commented Jun 9, 2026 •

edited

Loading

github-actions Bot commented Jun 9, 2026 •

edited

Loading