Fix Go example generator emitting invalid Go for RFC7231 datetime values by Copilot · Pull Request #4984 · Azure/typespec-azure

Copilot · 2026-07-21T05:24:06Z

The example generator produced uncompilable Go for utcDateTime properties encoded as rfc7231. getTimeValue's formatMap (in packages/typespec-go/src/codegen/core/example.ts) only handled RFC1123 and RFC3339, so RFC7231 fell through to the Unix-timestamp path — wrapping an unquoted, non-numeric date string in strconv.ParseInt. This regressed in Azure/autorest.go#1992, which switched the TypeSpec adapter to emit RFC7231 but updated servers.ts/operations.ts/models.ts/type.ts while missing example.ts.

Actual (broken):

LastExecuted: to.Ptr(func() time.Time { t, _ := strconv.ParseInt(05 May 2021 12:00:23 GMT, 10, 64); return time.Unix(t, 0).UTC()}()),

Now:

LastExecuted: to.Ptr(func() time.Time { t, _ := time.Parse(time.RFC1123, "05 May 2021 12:00:23 GMT"); return t}()),

Changes

core/example.ts: Add RFC7231: helpers.RFC1123Format to getTimeValue's formatMap, mirroring the existing mapping in fake/servers.ts. Both share the Go time.RFC1123 layout.
Changelog: Add a fix chronus entry for @azure-tools/typespec-go.

azure-pipelines · 2026-07-21T05:24:16Z

Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>

JiaqiZhang-Dev · 2026-07-21T05:46:49Z

@copilot

please follow this doc to add a scenario unitest for this change: https://github.com/Azure/typespec-azure/blob/main/packages/typespec-go/docs/development.md
2 you need to use pnpm change add to update the changelog, also help update the process for this doc: https://github.com/Azure/typespec-azure/blob/main/packages/typespec-go/docs/development.md#step-5-make-a-pr
you need to update package version in the package.json

…update dev doc Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>

Copilot · 2026-07-21T06:00:36Z

@copilot

please follow this doc to add a scenario unitest for this change: https://github.com/Azure/typespec-azure/blob/main/packages/typespec-go/docs/development.md
2 you need t...

Addressed all three in the latest commit:

Added an emitter scenario unit test (test/unittest/scenarios/rfc7231-datetime-sample.md, per the development doc) that compiles a @encode("rfc7231") utcDateTime property and snapshots the generated sample. It asserts the value is parsed with time.Parse(time.RFC1123, ...); I verified that reverting the fix makes the snapshot fail gofmt -s (uncompilable Go).
Regenerated the changelog with pnpm change add (replacing the hand-written change file), and updated Step 5 of the development doc to use pnpm change add.
Bumped @azure-tools/typespec-go to 0.15.1 in package.json, and documented the version-bump step in the development doc.

pkg-pr-new · 2026-07-21T08:10:31Z

Open in StackBlitz

npm i https://pkg.pr.new/@azure-tools/typespec-go@4984

commit: 3dc1ab9

JiaqiZhang-Dev · 2026-07-21T09:35:13Z

waiting for this pr merged: #4991

JiaqiZhang-Dev · 2026-07-22T01:30:28Z

@copilot resolve the merge conflicts in this pull request

…o-rfc7231-datetime # Conflicts: # packages/typespec-go/docs/development.md Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>

Copilot · 2026-07-22T01:33:05Z

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts by merging origin/main into this branch (merge commit af66c33). The only conflict was in packages/typespec-go/docs/development.md, where main reworded the changelog step; I kept the version-bump step and the pnpm change add wording (matching the repo convention). The RFC7231 fix in core/example.ts, the scenario test, and the version bump are all intact.

azure-sdk-automation · 2026-07-22T03:29:35Z

All changed packages have been documented.

✅ @azure-tools/typespec-go

Show changes

`@azure-tools/typespec-go` - fix ✏️

Fix the example generator emitting incorrect code for rfc7231 datatime.

azure-sdk-automation · 2026-07-22T03:38:51Z

You can try these changes here

🛝 Playground	🌐 Website

github-actions · 2026-07-22T06:07:48Z

Go emitter diff

Baseline gh:654134313d19dce661907728d0985920f30d0111 vs this PR.

No changes to generated output.

Rendered diff: inline on the run summary, or the emitter-diff-go-html artifact.

Informational check (core/eng/emitter-diff); does not block the PR.

Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>

jhendrixMSFT · 2026-07-22T16:24:28Z

+		Location: to.Ptr("eastus"),
+		Properties: &testmodule.WidgetProperties{
+			Description:  to.Ptr("my widget"),
+			LastExecuted: to.Ptr(func() time.Time { t, _ := time.Parse(time.RFC1123, "05 May 2021 12:00:23 GMT"); return t }()),


Callers should never need to manually parse time.Time into the wire format (we go to great lengths to not leak that implementation detail). Why do we need to do this here?

Since the example value is in wire format: 05 May 2021 12:00:23 GMT, we need to manually parse it into time.Time. For sdk customers, they don't need this logic, just give the time.Time is ok.

I'm not sure if you mean that we should analyze the wire format in the code, and then generate unified code like to.Ptr(time.Date(2021, time.May, 5, 12, 0, 23, 0, time.UTC))

Your example is correct.

The emitted code handles conversion to the correct wire format. All we should need to know is if we need to emit time.UTC or time.Local (the former should be the vast majority of cases.

FYI I'm going to fix this as part of #4956 which is in progress.

jhendrixMSFT · 2026-07-22T17:51:08Z

I don't see any changes in the generated diff, is this expected?

JiaqiZhang-Dev · 2026-07-27T03:40:14Z

I don't see any changes in the generated diff, is this expected?

Yes, since we haven’t had a test about RFC7231 before, there’s no change in the generated diff.

Initial plan

778f5dc

Copilot AI assigned Copilot and JiaqiZhang-Dev Jul 21, 2026

Copilot AI linked an issue Jul 21, 2026 that may be closed by this pull request

Example generator emits invalid Go for RFC7231 datetime values (regression from #1992) #4924

Open

Copilot started work on behalf of JiaqiZhang-Dev July 21, 2026 05:24 View session

Fix Go example generator for RFC7231 datetime values

39c538b

Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>

microsoft-github-policy-service Bot added the emitter:go Issues for @azure-tools/typespec-go emitter label Jul 21, 2026

Add chronus changelog for RFC7231 example fix

4c6f4f9

Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix invalid Go generation for RFC7231 datetime values~~ Fix Go example generator emitting invalid Go for RFC7231 datetime values Jul 21, 2026

Copilot finished work on behalf of JiaqiZhang-Dev July 21, 2026 05:29

Copilot AI requested a review from JiaqiZhang-Dev July 21, 2026 05:29

Copilot started work on behalf of JiaqiZhang-Dev July 21, 2026 05:47 View session

Add scenario test, chronus change via pnpm change add, bump version, …

a87ab32

…update dev doc Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>

Copilot finished work on behalf of JiaqiZhang-Dev July 21, 2026 06:01

Merge branch 'main' into copilot/fix-invalid-go-rfc7231-datetime

4922663

update changelog

8937e4a

Copilot started work on behalf of JiaqiZhang-Dev July 22, 2026 01:31 View session

Merge remote-tracking branch 'origin/main' into copilot/fix-invalid-g…

af66c33

…o-rfc7231-datetime # Conflicts: # packages/typespec-go/docs/development.md Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>

Copilot finished work on behalf of JiaqiZhang-Dev July 22, 2026 01:33

JiaqiZhang-Dev marked this pull request as ready for review July 22, 2026 03:27

JiaqiZhang-Dev requested review from bterlson, markcowl and timotheeguerin as code owners July 22, 2026 03:27

Merge branch 'main' into copilot/fix-invalid-go-rfc7231-datetime

bd781da

tadelesh reviewed Jul 22, 2026

View reviewed changes

Comment thread packages/typespec-go/docs/development.md Outdated

Comment thread packages/typespec-go/package.json Outdated

Copilot started work on behalf of JiaqiZhang-Dev July 22, 2026 06:18 View session

Revert typespec-go version bump and remove version-bump doc step

3dc1ab9

Co-authored-by: JiaqiZhang-Dev <194873822+JiaqiZhang-Dev@users.noreply.github.com>

Copilot finished work on behalf of JiaqiZhang-Dev July 22, 2026 06:20

Copilot started work on behalf of JiaqiZhang-Dev July 22, 2026 06:21 View session

Copilot finished work on behalf of JiaqiZhang-Dev July 22, 2026 06:22

tadelesh approved these changes Jul 22, 2026

View reviewed changes

jhendrixMSFT requested changes Jul 22, 2026

View reviewed changes

Copilot started work on behalf of JiaqiZhang-Dev July 27, 2026 01:47 View session

Copilot finished work on behalf of JiaqiZhang-Dev July 27, 2026 01:51

Azure deleted a comment from Copilot AI Jul 27, 2026

Uh oh!

Conversation

Copilot AI commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

azure-pipelines Bot commented Jul 21, 2026

Uh oh!

JiaqiZhang-Dev commented Jul 21, 2026

Uh oh!

Copilot AI commented Jul 21, 2026

Uh oh!

pkg-pr-new Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JiaqiZhang-Dev commented Jul 21, 2026

Uh oh!

JiaqiZhang-Dev commented Jul 22, 2026

Uh oh!

Copilot AI commented Jul 22, 2026

Uh oh!

azure-sdk-automation Bot commented Jul 22, 2026

@azure-tools/typespec-go - fix ✏️

Uh oh!

azure-sdk-automation Bot commented Jul 22, 2026

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Go emitter diff

Uh oh!

Uh oh!

Uh oh!

jhendrixMSFT Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

JiaqiZhang-Dev Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT commented Jul 22, 2026

Uh oh!

JiaqiZhang-Dev commented Jul 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 21, 2026 •

edited

Loading

pkg-pr-new Bot commented Jul 21, 2026 •

edited

Loading

`@azure-tools/typespec-go` - fix ✏️

github-actions Bot commented Jul 22, 2026 •

edited

Loading

jhendrixMSFT Jul 27, 2026 •

edited

Loading