fix(eng): trigger all emitter CI on any pnpm-workspace.yaml change - #5059
Merged
Conversation
pnpm attributes root pnpm-workspace.yaml edits to the root package only, so a catalog bump of an out-of-workspace upstream (e.g. @typespec/http-client-python) left every emitter target unaffected and the Python CI never ran. detect-affected now diffs the catalog / catalogs blocks between base and head, resolves the workspace packages that consume the changed entries via catalog: specifiers, and expands their dependents through the pnpm graph. Fixes #5010 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 19d6a84d-f603-41ee-8377-6dfb7e661391
Contributor
|
No changes needing a change description found. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 19d6a84d-f603-41ee-8377-6dfb7e661391
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 19d6a84d-f603-41ee-8377-6dfb7e661391
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 19d6a84d-f603-41ee-8377-6dfb7e661391
msyyc
changed the title
msyyc
marked this pull request as ready for review
July 27, 2026 09:16
msyyc
requested review from
bterlson,
markcowl and
timotheeguerin
as code owners
July 27, 2026 09:16
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes downstream CI target detection so that changes to the root pnpm-workspace.yaml (notably pnpm catalog bumps for non-workspace upstreams like @typespec/http-client-python) correctly trigger emitter CI jobs. It does this by treating pnpm-workspace.yaml as a “shared extra” path that forces all targets to be considered affected.
Changes:
- Add
pnpm-workspace.yamlto thesharedExtratrigger set so any change to it triggers all emitter targets. - Clarify
detect-affected.tsdocumentation around the pnpm catalog edge case and why the trigger is intentionally broad. - Add a unit test to ensure
pnpm-workspace.yamlchanges result in all targets being marked affected.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/scripts/detect-affected.ts | Documents the pnpm catalog edge case and relies on sharedExtra to force all targets on pnpm-workspace.yaml changes. |
| eng/scripts/detect-affected.test.ts | Adds a regression test asserting pnpm-workspace.yaml triggers all targets. |
| eng/scripts/detect-affected.config.json | Extends sharedExtra to include pnpm-workspace.yaml so it’s treated as shared CI infra. |
Contributor
|
You can try these changes here
|
timotheeguerin
approved these changes
Jul 27, 2026
msyyc
enabled auto-merge
July 28, 2026 02:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5010.
Problem
@typespec/http-client-pythonis not a workspace package — it is consumed from npm through the pnpm catalog, so bumping it only edits the rootpnpm-workspace.yaml.pnpm attributes root-file changes to the root package only, so
pnpm --filter "...[base]"reports no affected emitter anddetect-affectedreturnspython: false. That is why #5009 ran no Python CI.Fix
Add
pnpm-workspace.yamltosharedExtra, so any change to it triggers every emitter target — the same treatment thecoresubmodule pointer already gets.The file changes rarely and always affects dependency resolution repo-wide, so this is deliberately blunt rather than trying to work out which catalog entry moved.
Verification
Simulated the #5009 diff locally with
BASE_SHA=origin/main:Plus a unit test in
eng/scripts/detect-affected.test.ts.