Skip to content

Remove (dupe) application name from telemetry #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ V.NEXT
- [PATCH] Fix Error Type thrown for NO_ACCOUNT_FOUND (#2006)
- [PATCH] Pulling device cert issuer check to beginning of OnReceivedClientCertRequest (#2010)
- [MINOR] Add method to clear receiver concurrentHashMap in LocalBroadcaster (#1993)
- [MINOR] Remove (dupe) application name from telemetry (#2011)

V.11.0.0
----------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ public AcquireTokenResult execute() throws Exception {
final Span span = OTelUtility.createSpanFromParent(
SpanName.AcquireTokenInteractive.name(), getParameters().getSpanContext()
);
span.setAttribute(AttributeName.application_name.name(), getParameters().getApplicationName());
span.setAttribute(AttributeName.public_api_id.name(), getPublicApiId());

try (final Scope scope = span.makeCurrent()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ public AcquireTokenResult execute() throws Exception {
final Span span = OTelUtility.createSpanFromParent(
SpanName.AcquireTokenSilent.name(), getParameters().getSpanContext()
);
span.setAttribute(AttributeName.application_name.name(), getParameters().getApplicationName());
span.setAttribute(AttributeName.public_api_id.name(), getPublicApiId());

try (final Scope scope = span.makeCurrent()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,6 @@ public enum AttributeName {
*/
controller_name,

/**
* The name of the application making the request.
*/
application_name,

/**
* Indicates if token was return from token cache
*/
Expand Down