Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SigninSilent only] CommonCore interface for XPC silent request. #1482

Merged
merged 24 commits into from
Apr 1, 2025
+1,380 −167
Merged

[SigninSilent only] CommonCore interface for XPC silent request. #1482

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
524bc55
initial work to add silent xpc token request and controller
Oct 4, 2024
67398ab
Remove pre-check on canPerform
Oct 5, 2024
f1f6c96
Add requestType for telemetry usage in broker
Oct 5, 2024
b830a97
Merge branch 'dev' into kasong/2914053-common-interface
Oct 23, 2024
32c71df
Merge branch 'dev' into kasong/2914053-common-interface
Nov 21, 2024
23334a8
Add can perform request
Nov 22, 2024
dc19668
Merge branch 'dev' into kasong/2914053-common-interface
Feb 11, 2025
7024e55
initial commit to add XPC interface for silent token request
Feb 12, 2025
7721a7c
Remove crypto part for response
Feb 14, 2025
019d5d3
add UTs to check fallback controlers' order
Feb 22, 2025
9bd5556
Add enum to enabl/disable XPC service
Feb 26, 2025
5603852
add enum to support xpc mode
Feb 26, 2025
195252b
Merge branch 'dev' into kasong/2914053-common-interface
Feb 26, 2025
4861e4b
Remove ssoPerf telemetry
Feb 26, 2025
7312a98
Make sure status code is used in log
Feb 26, 2025
4d799e4
Merge branch 'dev' into kasong/2914053-common-interface
Mar 11, 2025
1b68c57
Add param control to use v2 XPC controller factory or V1 original con…
Mar 11, 2025
453e551
Address CR
Mar 13, 2025
447af73
remove msid prefix
Mar 13, 2025
1191653
Fix a typo
Mar 14, 2025
09c4f62
Address CR
Mar 19, 2025
28e84c5
Remove unused file reference in project folder
Mar 31, 2025
b3be88b
Merge branch 'dev' into kasong/2914053-common-interface
Mar 31, 2025
f1fca84
Add missing ref back
Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions IdentityCore/IdentityCore.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,15 @@
23FB5C452255A11D002BF1EB /* MSIDClaimsRequest.m in Sources */ = {isa = PBXBuildFile; fileRef = 23FB5C24225517AA002BF1EB /* MSIDClaimsRequest.m */; };
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update changelog.txt.

Please consider if this change would be noticeable to a partner or user and either update changelog.txt or resolve this conversation.

23FB5C462255A135002BF1EB /* MSIDIndividualClaimRequest.m in Sources */ = {isa = PBXBuildFile; fileRef = 23FB5C29225517AA002BF1EB /* MSIDIndividualClaimRequest.m */; };
23FB5C472255A13A002BF1EB /* MSIDIndividualClaimRequestAdditionalInfo.m in Sources */ = {isa = PBXBuildFile; fileRef = 23FB5C27225517AA002BF1EB /* MSIDIndividualClaimRequestAdditionalInfo.m */; };
2A24814D2CB06A1A006FCB34 /* MSIDSSORemoteSilentTokenRequest.m in Sources */ = {isa = PBXBuildFile; fileRef = 2A24814C2CB06A1A006FCB34 /* MSIDSSORemoteSilentTokenRequest.m */; };
2A24814E2CB06A1A006FCB34 /* MSIDSSORemoteSilentTokenRequest.h in Headers */ = {isa = PBXBuildFile; fileRef = 2A24814B2CB06A1A006FCB34 /* MSIDSSORemoteSilentTokenRequest.h */; };
2A24814F2CB06A1A006FCB34 /* MSIDSSORemoteSilentTokenRequest.m in Sources */ = {isa = PBXBuildFile; fileRef = 2A24814C2CB06A1A006FCB34 /* MSIDSSORemoteSilentTokenRequest.m */; };
2A2481532CB07BCC006FCB34 /* MSIDSSOXpcSilentTokenRequest.m in Sources */ = {isa = PBXBuildFile; fileRef = 2A2481512CB07BCC006FCB34 /* MSIDSSOXpcSilentTokenRequest.m */; };
2A2481542CB07BCC006FCB34 /* MSIDSSOXpcSilentTokenRequest.h in Headers */ = {isa = PBXBuildFile; fileRef = 2A2481502CB07BCC006FCB34 /* MSIDSSOXpcSilentTokenRequest.h */; };
2A2481582CB08050006FCB34 /* MSIDXpcSingleSignOnProvider.m in Sources */ = {isa = PBXBuildFile; fileRef = 2A2481562CB08050006FCB34 /* MSIDXpcSingleSignOnProvider.m */; };
2A2481592CB08050006FCB34 /* MSIDXpcSingleSignOnProvider.h in Headers */ = {isa = PBXBuildFile; fileRef = 2A2481552CB08050006FCB34 /* MSIDXpcSingleSignOnProvider.h */; };
2A24815F2CB08344006FCB34 /* MSIDXpcSilentTokenRequestController.m in Sources */ = {isa = PBXBuildFile; fileRef = 2A24815D2CB08344006FCB34 /* MSIDXpcSilentTokenRequestController.m */; };
2A2481602CB08344006FCB34 /* MSIDXpcSilentTokenRequestController.h in Headers */ = {isa = PBXBuildFile; fileRef = 2A24815C2CB08344006FCB34 /* MSIDXpcSilentTokenRequestController.h */; };
2A0278912D6E3216005655B4 /* MSIDAADTokenRequestServerTelemetryTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 2A0278902D6E3216005655B4 /* MSIDAADTokenRequestServerTelemetryTests.m */; };
2A0278922D6E3216005655B4 /* MSIDAADTokenRequestServerTelemetryTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 2A0278902D6E3216005655B4 /* MSIDAADTokenRequestServerTelemetryTests.m */; };
2A0278A32D6E3787005655B4 /* MSIDLastRequestTelemetry+Tests.h in Headers */ = {isa = PBXBuildFile; fileRef = 2A0278A22D6E3787005655B4 /* MSIDLastRequestTelemetry+Tests.h */; };
Expand Down Expand Up @@ -2395,6 +2404,14 @@
23FB5C2E22551866002BF1EB /* MSIDClaimsRequest+ClientCapabilities.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = "MSIDClaimsRequest+ClientCapabilities.m"; sourceTree = "<group>"; };
23FB5C32225585E6002BF1EB /* MSIDClaimsRequestMock.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = MSIDClaimsRequestMock.h; sourceTree = "<group>"; };
23FB5C33225585E6002BF1EB /* MSIDClaimsRequestMock.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = MSIDClaimsRequestMock.m; sourceTree = "<group>"; };
2A24814B2CB06A1A006FCB34 /* MSIDSSORemoteSilentTokenRequest.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = MSIDSSORemoteSilentTokenRequest.h; sourceTree = "<group>"; };
2A24814C2CB06A1A006FCB34 /* MSIDSSORemoteSilentTokenRequest.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = MSIDSSORemoteSilentTokenRequest.m; sourceTree = "<group>"; };
2A2481502CB07BCC006FCB34 /* MSIDSSOXpcSilentTokenRequest.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = MSIDSSOXpcSilentTokenRequest.h; sourceTree = "<group>"; };
2A2481512CB07BCC006FCB34 /* MSIDSSOXpcSilentTokenRequest.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = MSIDSSOXpcSilentTokenRequest.m; sourceTree = "<group>"; };
2A2481552CB08050006FCB34 /* MSIDXpcSingleSignOnProvider.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = MSIDXpcSingleSignOnProvider.h; sourceTree = "<group>"; };
2A2481562CB08050006FCB34 /* MSIDXpcSingleSignOnProvider.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = MSIDXpcSingleSignOnProvider.m; sourceTree = "<group>"; };
2A24815C2CB08344006FCB34 /* MSIDXpcSilentTokenRequestController.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = MSIDXpcSilentTokenRequestController.h; sourceTree = "<group>"; };
2A24815D2CB08344006FCB34 /* MSIDXpcSilentTokenRequestController.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = MSIDXpcSilentTokenRequestController.m; sourceTree = "<group>"; };
2A0278902D6E3216005655B4 /* MSIDAADTokenRequestServerTelemetryTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = MSIDAADTokenRequestServerTelemetryTests.m; sourceTree = "<group>"; };
2A0278A22D6E3787005655B4 /* MSIDLastRequestTelemetry+Tests.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "MSIDLastRequestTelemetry+Tests.h"; sourceTree = "<group>"; };
51E364572863C0F300A97F82 /* MSIDTelemetryConditionalCompile.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MSIDTelemetryConditionalCompile.h; sourceTree = "<group>"; };
Expand Down Expand Up @@ -5103,6 +5120,10 @@
B49323A02AD4DB2700E0CBC0 /* MSIDSSOExtensionPasskeyAssertionRequest.m */,
B443EFF02AD6299300782168 /* MSIDSSOExtensionPasskeyCredentialRequest.h */,
B443EFF12AD629A300782168 /* MSIDSSOExtensionPasskeyCredentialRequest.m */,
2A24814B2CB06A1A006FCB34 /* MSIDSSORemoteSilentTokenRequest.h */,
2A24814C2CB06A1A006FCB34 /* MSIDSSORemoteSilentTokenRequest.m */,
2A2481502CB07BCC006FCB34 /* MSIDSSOXpcSilentTokenRequest.h */,
2A2481512CB07BCC006FCB34 /* MSIDSSOXpcSilentTokenRequest.m */,
);
path = broker;
sourceTree = "<group>";
Expand All @@ -5117,6 +5138,8 @@
23B5DF7B234031ED002C530F /* MSIDSSOExtensionSilentTokenRequestController.m */,
B217863623A5994300839CE8 /* MSIDSSOExtensionSignoutController.h */,
B217863723A5994300839CE8 /* MSIDSSOExtensionSignoutController.m */,
2A24815C2CB08344006FCB34 /* MSIDXpcSilentTokenRequestController.h */,
2A24815D2CB08344006FCB34 /* MSIDXpcSilentTokenRequestController.m */,
);
path = broker;
sourceTree = "<group>";
Expand Down Expand Up @@ -5298,6 +5321,8 @@
728209CF26FEA0F600B5F018 /* MSIDKeyOperationUtil.m */,
237777C82853FF9400DDEAFC /* ASAuthorizationController+MSIDExtensions.h */,
237777C92853FF9400DDEAFC /* ASAuthorizationController+MSIDExtensions.m */,
2A2481552CB08050006FCB34 /* MSIDXpcSingleSignOnProvider.h */,
2A2481562CB08050006FCB34 /* MSIDXpcSingleSignOnProvider.m */,
);
path = util;
sourceTree = "<group>";
Expand Down Expand Up @@ -5853,6 +5878,7 @@
232C65882138BDC5002A41FE /* MSIDAADAuthorityMetadataResponse.h in Headers */,
23C548052A2A5DBF00633DC0 /* MSIDBrokerOperationBrowserNativeMessageRequest.h in Headers */,
B2C7089C219926C200D917B8 /* MSIDBrokerResponse+Internal.h in Headers */,
2A2481602CB08344006FCB34 /* MSIDXpcSilentTokenRequestController.h in Headers */,
B286B9C72389DE7F007833AD /* MSIDAccountMetadataCacheAccessor.h in Headers */,
B286B9B12389DD6C007833AD /* MSIDPKeyAuthHandler.h in Headers */,
E733EDD525C0A47600ACB79A /* MSIDThumbprintCalculatable.h in Headers */,
Expand All @@ -5869,6 +5895,7 @@
74D926C324B3EFC300AA4270 /* MSIDLastRequestTelemetry+Internal.h in Headers */,
235480CA20DDF81000246F72 /* MSIDAuthorityFactory.h in Headers */,
58BC2392271E0D94008A77BE /* MSIDSSOExtensionGetSsoCookiesRequest.h in Headers */,
2A24814E2CB06A1A006FCB34 /* MSIDSSORemoteSilentTokenRequest.h in Headers */,
B217863823A5994300839CE8 /* MSIDSSOExtensionSignoutController.h in Headers */,
A0C7DE4425D4522300F5B5B6 /* MSIDThrottlingModelFactory.h in Headers */,
B286B9942389DC76007833AD /* MSIDDefaultTokenRequestProvider+Internal.h in Headers */,
Expand Down Expand Up @@ -6040,6 +6067,7 @@
58E2A1FC24E497400027A28A /* MSIDWebResponseOperationConstants.h in Headers */,
5887EBF12BBF6490005F9634 /* MSIDAuthenticationSchemeSshCert.h in Headers */,
B2AF1D2E218BCEDE0080C1A0 /* MSIDInteractiveTokenRequest.h in Headers */,
2A2481592CB08050006FCB34 /* MSIDXpcSingleSignOnProvider.h in Headers */,
1E707FE22407337300716148 /* MSIDBrokerOperationResponse.h in Headers */,
B251CC48204105A7005E0179 /* MSIDBaseToken.h in Headers */,
1E62D0E6228B760A000E2BBC /* MSIDKeychainUtil.h in Headers */,
Expand Down Expand Up @@ -6168,6 +6196,7 @@
74F04D4D246CB5B100094017 /* MSIDCurrentRequestTelemetrySerializedItem+Internal.h in Headers */,
238E19DD2086FE28004DF483 /* MSIDAADAuthorizationCodeRequest.h in Headers */,
B227037622A4C29800030ADC /* MSIDExtendedTokenCacheDataSource.h in Headers */,
2A2481542CB07BCC006FCB34 /* MSIDSSOXpcSilentTokenRequest.h in Headers */,
B251CC49204105A7005E0179 /* MSIDIdToken.h in Headers */,
B2F671EC2467AB4500649855 /* MSIDInteractiveRequestControlling.h in Headers */,
B443F0002AD6327700782168 /* MSIDBrokerOperationPasskeyCredentialRequest.h in Headers */,
Expand Down Expand Up @@ -7070,12 +7099,14 @@
580E2547271A014F003D1795 /* MSIDDeviceHeader.m in Sources */,
583BFCAB24D88CED0035B901 /* MSIDRedirectUriVerifier.m in Sources */,
B253152723DD61FB00432133 /* MSIDSSOExtensionGetDeviceInfoRequest.m in Sources */,
2A24815F2CB08344006FCB34 /* MSIDXpcSilentTokenRequestController.m in Sources */,
23C548062A2A5DBF00633DC0 /* MSIDBrokerOperationBrowserNativeMessageRequest.m in Sources */,
238D5D8C22B353830091A135 /* MSIDAADV2TokenResponseForV1Request.m in Sources */,
2352AF342AA7C7B700FA2253 /* MSIDBrowserNativeMessageGetTokenResponse.m in Sources */,
589BDB292718F18800BF3799 /* MSIDCredentialHeader.m in Sources */,
B25A356F1FC4D70300C7FD43 /* MSIDLogger.m in Sources */,
5887EBF32BBF6490005F9634 /* MSIDAuthenticationSchemeSshCert.m in Sources */,
2A2481532CB07BCC006FCB34 /* MSIDSSOXpcSilentTokenRequest.m in Sources */,
B2C7088F2198E48E00D917B8 /* NSData+AES.m in Sources */,
96F21B3320A65896002B87C3 /* MSIDWebviewAuthorization.m in Sources */,
B27893832470CFE700627C28 /* MSIDAssymetricKeyGeneratorFactory.m in Sources */,
Expand All @@ -7098,6 +7129,7 @@
23FB5C3122551866002BF1EB /* MSIDClaimsRequest+ClientCapabilities.m in Sources */,
23B39ACD209CF317000AA905 /* MSIDAADNetworkConfiguration.m in Sources */,
23FB5C462255A135002BF1EB /* MSIDIndividualClaimRequest.m in Sources */,
2A2481582CB08050006FCB34 /* MSIDXpcSingleSignOnProvider.m in Sources */,
238F80A222C2BE1600437CB1 /* MSIDGetV1IdTokenHttpEvent.m in Sources */,
60BE060D23A1A3ED00CDA662 /* MSIDDeviceInfo.m in Sources */,
23071657229F56AE00FDD044 /* MSIDAADV2Oauth2FactoryForV1Request.m in Sources */,
Expand Down Expand Up @@ -7312,6 +7344,7 @@
B28D90A7218FD1E800E230D6 /* MSIDLegacyTokenResponseValidator.m in Sources */,
1E5319AA24A425B7007BCF30 /* MSIDAuthenticationScheme.m in Sources */,
B286B99F2389DCBA007833AD /* MSIDRequestParameters+Broker.m in Sources */,
2A24814D2CB06A1A006FCB34 /* MSIDSSORemoteSilentTokenRequest.m in Sources */,
B26A0B7F2071ADCE006BD95A /* MSIDOauth2Factory.m in Sources */,
B217863A23A5994300839CE8 /* MSIDSSOExtensionSignoutController.m in Sources */,
B2C707FF2192530E00D917B8 /* MSIDDefaultSilentTokenRequest.m in Sources */,
Expand Down Expand Up @@ -7844,6 +7877,7 @@
609E74CB228DE23B005E3FED /* MSIDAccountMetadataCacheKey.m in Sources */,
B2807FF8204CAFDF00944D89 /* MSIDHelpers.m in Sources */,
2317FFBD2A43988900E3DAA2 /* MSIDBrokerOperationBrowserNativeMessageRequest.m in Sources */,
2A24814F2CB06A1A006FCB34 /* MSIDSSORemoteSilentTokenRequest.m in Sources */,
23B018C32356D51200207FEC /* NSDictionary+MSIDQueryItems.m in Sources */,
580E2546271A014F003D1795 /* MSIDDeviceHeader.m in Sources */,
234DE5842A9456F600E244B3 /* MSIDBrowserNativeMessageRequest.m in Sources */,
Expand Down
8 changes: 8 additions & 0 deletions IdentityCore/src/MSIDConstants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,14 @@ typedef NS_ENUM(NSInteger, MSIDHeaderType)
MSIDHeaderTypeDeviceRegistration
};

typedef NS_ENUM(NSUInteger, MSIDXpcMode)
{
MSIDXpcModeDisable = 0,
MSIDXpcModeBackup,
MSIDXpcModeFull,
MSIDXpcModeOverride
};

typedef void (^MSIDRequestCompletionBlock)(MSIDTokenResult * _Nullable result, NSError * _Nullable error);
typedef void (^MSIDSignoutRequestCompletionBlock)(BOOL success, NSError * _Nullable error);
typedef void (^MSIDGetAccountsRequestCompletionBlock)(NSArray<MSIDAccount *> * _Nullable accounts, BOOL returnBrokerAccountsOnly, NSError * _Nullable error);
Expand Down
Loading
Loading