Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to MSAL contributing guide #4388

Merged
merged 4 commits into from
Oct 23, 2023
Merged

add to MSAL contributing guide #4388

merged 4 commits into from
Oct 23, 2023

Conversation

kllysng
Copy link
Contributor

@kllysng kllysng commented Oct 19, 2023

Adapted the team contributing guide to the one in MSAL. Did not remove anything from the original MSAL guide as it had a lot of great information, and I think the newest additions plug in nicely.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've made some minor changes, including combing the tests sections and moving fork related section after merging a PR section.

@pmaytak pmaytak requested a review from localden October 20, 2023 05:16
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@localden
Copy link
Collaborator

This is great, thank you @kellyyangsong!

@pmaytak pmaytak enabled auto-merge (squash) October 20, 2023 21:44
@pmaytak pmaytak disabled auto-merge October 23, 2023 21:52
@pmaytak pmaytak merged commit 7d5bcce into main Oct 23, 2023
6 checks passed
@pmaytak pmaytak deleted the kellysong/contribting branch October 23, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants