-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating code coverage config #4983
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trwalke
changed the title
Create CodeCoverage.yml
[DO NOT REVIEW] Create CodeCoverage.yml
Oct 31, 2024
trwalke
changed the title
[DO NOT REVIEW] Create CodeCoverage.yml
[DO NOT REVIEW] Updating code coverage
Nov 1, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
bgavrilMS
reviewed
Nov 11, 2024
bgavrilMS
reviewed
Nov 11, 2024
trwalke
changed the title
[DO NOT REVIEW] Updating code coverage
Updating code coverage config
Nov 13, 2024
bgavrilMS
approved these changes
Nov 13, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
bgavrilMS
approved these changes
Nov 15, 2024
gladjohn
approved these changes
Nov 17, 2024
trwalke
commented
Nov 19, 2024
Co-authored-by: Gladwin Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this request
Updating code coverage config
Testing
Did a local check with the latest config and the numbers are close
The issue with the build is that the code coverage config is unable to remove additional
.dll
s and.exe
s so the overall result is skewed in the build pipeline.However, we are still able to read the results and see the code coverage manually in the pipeline and run the coverage check locally.