Skip to content

Conversation

@Avery-Dunn
Copy link
Contributor

@Avery-Dunn Avery-Dunn commented Dec 5, 2025

Migrating test infrastructure, similar to what is being done in other MSALs:
AzureAD/microsoft-authentication-library-for-java#1002
AzureAD/microsoft-authentication-library-for-dotnet#5558

This PR adjusts the way integration tests get configuration: rather than reach out to our API, it instead retrieves similar config responses from Azure Key Vault. It does using packages from Azure SDK, new helper methods, and small changes to existing tests:

  • New usage of azcore and azsecrets packages to access the key vault
  • New helper functions, following the same naming scheme as existing functions exception with "kV" at the start
    • The "kV" part of the name is only temporary to help compare the old behavior with the new behavior, once the conversion is done the "kV" part will be dropped and the existing API-based functions will be fully replaced or removed
  • Small adjustments to existing tests to use the new behavior

Currently a draft to get an initial review and help compare the old and new systems, and will be made a full PR once all the tests are converted.

… from Key Vault instead of our API in several tests.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants