Skip to content

Update documentation in msal-node-samples #6953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

teofilomonteiro
Copy link

@teofilomonteiro teofilomonteiro commented Mar 14, 2024

  • Update documentation to reflect the required env property

@github-actions github-actions bot added documentation Related to documentation. samples Related to the samples apps for the library. labels Mar 14, 2024
@Robbie-Microsoft
Copy link
Collaborator

It appears this consistency appears in a few other node samples. @teofilomonteiro are you interested in making this change to the other relevant node samples?

@Robbie-Microsoft
Copy link
Collaborator

It appears this consistency appears in a few other node samples. @teofilomonteiro are you interested in making this change to the other relevant node samples?

@teofilomonteiro If you're planning on fixing this inconsistency in the other flows, can you do so in this PR? If not, let me know, and we can try and get this PR merged in as it is.

@teofilomonteiro
Copy link
Author

@Robbie-Microsoft I will try to review this inconsistency, later this week!

Copy link
Contributor

Reminder: This PR appears to be stale. If this PR is still a work in progress please mark as draft.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Apr 8, 2024
@teofilomonteiro teofilomonteiro marked this pull request as draft April 8, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. Needs: Attention 👋 Awaiting response from the MSAL.js team samples Related to the samples apps for the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants