Skip to content

Conversation

@arjenbloemsma
Copy link

@arjenbloemsma arjenbloemsma commented Jan 31, 2025

Please note that this is a "copy" of PR #7467 which got accidentally closed while doing an update to resolve conflicts

React 19 stable has been released on December 5th (see announcement). This PR updates the react packages to version 19 and also sets the peerDependecies to reflect this.

This change will allow msal-react to be used in projects that use react 19 and enables existing projects that use react and msal-react to upgrade to react 19.

All test succeed:

image

See issue #7455

@github-actions github-actions bot added the msal-react Related to @azure/msal-react label Jan 31, 2025
@arjenbloemsma arjenbloemsma force-pushed the chore/update-to-react-19 branch from ee2652f to 6383620 Compare January 31, 2025 16:30
@iampoul
Copy link

iampoul commented Feb 18, 2025

What needs to be done for this to go out of draft.

"@types/node": "^20.5.1",
"@types/react": "^18.2.13",
"@types/react-dom": "^18.2.6",
"@types/react": "^19.0.01",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@types/react": "^19.0.01",
"@types/react": "^19.0.10",

@antonakospanos
Copy link

@arjenbloemsma we would also like to upgrade our stack to React 19 and we are stuck because of this. Are you ok accepting the suggestion so that we include this in the next release?

@JackMorganNZ
Copy link

Similar to others here, our path to React 19 is blocked due to this package. @arjenbloemsma Is this okay to be marked as ready? Is there anything we can do to assist?

@LeonFedotov
Copy link

@tnorling do you mind taking a look please?

@samuelms1
Copy link

Really excited for the React 19 support. It's the last package holding up my company's upgrade. Super appreciate @arjenbloemsma opening the PR and others that contribute to the repo.

@julesblancphin
Copy link

Any updates on this? @tnorling @jo-arroyo @peterzenz, the community has been eagerly waiting for react 19 support for 4 months now. Thanks.

@binu1-pararath-c5i-ai
Copy link

Is this held up because of genuine reasons? Will it be a good idea if someone confident enough shall fork msal-react and msal-browser and break this seemingly indefinite wait?

@samuelms1
Copy link

Is this held up because of genuine reasons? Will it be a good idea if someone confident enough shall fork msal-react and msal-browser and break this seemingly indefinite wait?

Not sure about why it's being held up but as suggested by some others, simply applying overrides works just fine. I've been using MSAL with React 19 for a couple weeks with no issues. Unrelated, but I had to do the same thing with swagger-ui-react too.

I really appreciate the folks that keep these libraries nice. They're doing a lot.

Here's the post that I followed and it worked perfectly:

I've managed to upgrade to react@19 by adding "overrides" in package.json. Haven't run into any issues since January

"overrides": {
  "@azure/msal-react": {
    "react": "^16.8.0 || ^17 || ^18 || ^19"
  }
}

See #7577 (comment)

@tnorling
Copy link
Collaborator

tnorling commented May 6, 2025

Closing in favor of #7735

@tnorling tnorling closed this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

msal-react Related to @azure/msal-react

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants