-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Signin #7620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: custom-auth/main
Are you sure you want to change the base?
Signin #7620
Conversation
@@ -0,0 +1,65 @@ | |||
"use client"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend calling the pages AttributesPage, CodePage, PasswordPage so that the client doesn't get confused where the code goes and how it's structured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spetrescu84 the entry point of a route cannot be renamed in nextjs, it needs a page.tsx file for routes. Read here https://nextjs.org/docs/app/getting-started/layouts-and-pages#pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it can but it becomes too complex - https://nextjs.org/docs/pages/api-reference/config/next-config-js/pageExtensions. We can leave as is.
|
||
const handleSubmitCode = async () => { | ||
if (authState instanceof SignUpCodeRequired) { | ||
const handler = AuthFlowStateHandlerFactory.create(authState); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't this one be moved inside the sdk? So there is an authState.handler which gets returned? Even if it's not used, it's a much better user experience to just say authState.handler.submitCode?
No description provided.