-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Added token revocation functionality to Managed Identity's Service Fabric source #7679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
920bac3
73ffd22
f4f002a
468de01
dcd382f
d8fbbca
b09a464
0f7b2b9
b32f45e
604194d
3405bce
f1d096f
203d5d0
d9f15e6
0832c02
753ec2b
aa2a42d
0f15894
b48caf9
865697d
2295235
c34e1e4
f9b13fb
e7e0af7
4a59853
a3434fa
77c94d0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "minor", | ||
"comment": "Added token revocation functionality to Managed Identity's App Service and Service Fabric Sources #7679", | ||
"packageName": "@azure/msal-node", | ||
"email": "[email protected]", | ||
"dependentChangeType": "patch" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,20 +7,19 @@ import { INetworkModule, Logger } from "@azure/msal-common/node"; | |
import { BaseManagedIdentitySource } from "./BaseManagedIdentitySource.js"; | ||
import { | ||
HttpMethod, | ||
APP_SERVICE_SECRET_HEADER_NAME, | ||
API_VERSION_QUERY_PARAMETER_NAME, | ||
RESOURCE_BODY_OR_QUERY_PARAMETER_NAME, | ||
ManagedIdentityEnvironmentVariableNames, | ||
ManagedIdentitySourceNames, | ||
ManagedIdentityIdType, | ||
ManagedIdentityQueryParameters, | ||
ManagedIdentityHeaders, | ||
} from "../../utils/Constants.js"; | ||
import { CryptoProvider } from "../../crypto/CryptoProvider.js"; | ||
import { ManagedIdentityRequestParameters } from "../../config/ManagedIdentityRequestParameters.js"; | ||
import { ManagedIdentityId } from "../../config/ManagedIdentityId.js"; | ||
import { NodeStorage } from "../../cache/NodeStorage.js"; | ||
|
||
// MSI Constants. Docs for MSI are available here https://docs.microsoft.com/azure/app-service/overview-managed-identity | ||
const APP_SERVICE_MSI_API_VERSION: string = "2019-08-01"; | ||
const APP_SERVICE_MSI_API_VERSION: string = "2025-03-30"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please do not merge this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alternatively, remove the app service changes from this PR, and then we can merge it for Service Fabric. We will create a new PR later after app service deploys their token revocation support. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @gladjohn Expected GA for App Service token revocation is 5/30? I will wait to merge until then if you can confirm. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
5/30 is availability of the feature in test ring. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the timeline for it to be available in prod? I am expecting that we will not merge until this is available in prod. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As of now PROD for SF and App Service is 6/30 |
||
|
||
/** | ||
* Original source of code: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/identity/Azure.Identity/src/AppServiceManagedIdentitySource.cs | ||
|
@@ -114,11 +113,12 @@ export class AppService extends BaseManagedIdentitySource { | |
this.identityEndpoint | ||
); | ||
|
||
request.headers[APP_SERVICE_SECRET_HEADER_NAME] = this.identityHeader; | ||
request.headers[ManagedIdentityHeaders.APP_SERVICE_SECRET_HEADER_NAME] = | ||
this.identityHeader; | ||
|
||
request.queryParameters[API_VERSION_QUERY_PARAMETER_NAME] = | ||
request.queryParameters[ManagedIdentityQueryParameters.API_VERSION] = | ||
APP_SERVICE_MSI_API_VERSION; | ||
request.queryParameters[RESOURCE_BODY_OR_QUERY_PARAMETER_NAME] = | ||
request.queryParameters[ManagedIdentityQueryParameters.RESOURCE] = | ||
resource; | ||
|
||
if ( | ||
|
Uh oh!
There was an error while loading. Please reload this page.