Skip to content

Move auth error messages out of the bundle #7744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: msal-v5
Choose a base branch
from
Open

Move auth error messages out of the bundle #7744

wants to merge 5 commits into from

Conversation

konstantin-msft
Copy link
Collaborator

  • Move auth error messages out of the bundle

@github-actions github-actions bot added documentation Related to documentation. msal-node Related to msal-node package msal-browser Related to msal-browser package msal-common Related to msal-common package labels May 12, 2025
@konstantin-msft konstantin-msft marked this pull request as ready for review May 13, 2025 18:29
tnorling
tnorling reviewed May 14, 2025
View reviewed changes
lib/msal-common/src/error/AuthError.ts
"Post request failed from the network, could be a 4xx/5xx or a network unavailability. Please check the exact error code for details.",
};
export function getDefaultErrorMessage(code: string): string {
return `See https://aka.ms/msaljs/common/errors#${code} for details`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now but I think eventually it would be good to just have a single source of truth for all Errors

tnorling
tnorling approved these changes May 14, 2025
View reviewed changes
Copy link
Collaborator

@tnorling tnorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also like to see some sort of CI validation that a message actually exists in the doc for all error codes. I'm happy to treat that as its own separate work item, however, just calling it out as a requirement to call this work complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnorling tnorling tnorling approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

@lalimasharda lalimasharda Awaiting requested review from lalimasharda lalimasharda is a code owner

@shylasummers shylasummers Awaiting requested review from shylasummers shylasummers is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
documentation Related to documentation. msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konstantin-msft @tnorling