-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Merge dev into v5 #7748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jo-arroyo
wants to merge
24
commits into
msal-v5
Choose a base branch
from
merge-v5-to-dev-5-13-25
base: msal-v5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Merge dev into v5 #7748
+6,627
−2,955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a race condition that can occur between cache initialization and react state initialization Fixes #7654, #7561 --------- Co-authored-by: Jo Arroyo <[email protected]>
If the GET/POST calls fail, say in case of CORS header missing cases, we do not post the exact error seen in the JS to the application. This PR updates the same and also changes the error type to NetworkError.
Adds jest-junit to jest reporters. This will allow us to report test results on the ADO pipelines and identify flaky tests
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 3.2.11 to 4.5.14. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vitejs/vite/releases">vite's releases</a>.</em></p> <blockquote> <h2>v4.5.14</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v4.5.14/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>v4.5.13</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v4.5.13/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>v4.5.12</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v4.5.12/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>v4.5.11</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v4.5.11/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>v4.5.10</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v4.5.10/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>v4.5.9</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v4.5.9/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>v4.5.8</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v4.5.8/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>v4.5.7</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v4.5.7/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>v4.5.6</h2> <p>This version contains a breaking change due to security fixes. See <a href="https://github.com/vitejs/vite/security/advisories/GHSA-vg6x-rcgg-rjx6">https://github.com/vitejs/vite/security/advisories/GHSA-vg6x-rcgg-rjx6</a> for more details.</p> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v4.5.6/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/vitejs/vite/blob/v4.5.14/packages/vite/CHANGELOG.md">vite's changelog</a>.</em></p> <blockquote> <h2><!-- raw HTML omitted -->4.5.14 (2025-04-30)<!-- raw HTML omitted --></h2> <ul> <li>fix: backport <a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19965">#19965</a>, check static serve file inside sirv (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19967">#19967</a>) (<a href="https://github.com/vitejs/vite/commit/7739479">7739479</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/19965">#19965</a> <a href="https://redirect.github.com/vitejs/vite/issues/19967">#19967</a></li> <li>chore: run format (<a href="https://github.com/vitejs/vite/commit/99afb60">99afb60</a>)</li> </ul> <h2><!-- raw HTML omitted -->4.5.13 (2025-04-10)<!-- raw HTML omitted --></h2> <ul> <li>fix: backport <a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19830">#19830</a>, reject requests with <code>#</code> in request-target (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19832">#19832</a>) (<a href="https://github.com/vitejs/vite/commit/41f3819">41f3819</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/19830">#19830</a> <a href="https://redirect.github.com/vitejs/vite/issues/19832">#19832</a></li> </ul> <h2><!-- raw HTML omitted -->4.5.12 (2025-04-03)<!-- raw HTML omitted --></h2> <ul> <li>fix: backport <a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19782">#19782</a>, fs check with svg and relative paths (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19785">#19785</a>) (<a href="https://github.com/vitejs/vite/commit/0a3dcf5">0a3dcf5</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/19782">#19782</a> <a href="https://redirect.github.com/vitejs/vite/issues/19785">#19785</a></li> </ul> <h2><!-- raw HTML omitted -->4.5.11 (2025-03-31)<!-- raw HTML omitted --></h2> <ul> <li>fix: backport <a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19761">#19761</a>, fs check in transform middleware (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19763">#19763</a>) (<a href="https://github.com/vitejs/vite/commit/26e1764">26e1764</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/19761">#19761</a> <a href="https://redirect.github.com/vitejs/vite/issues/19763">#19763</a></li> </ul> <h2><!-- raw HTML omitted -->4.5.10 (2025-03-24)<!-- raw HTML omitted --></h2> <ul> <li>fix: backport <a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19702">#19702</a>, fs raw query with query separators (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19704">#19704</a>) (<a href="https://github.com/vitejs/vite/commit/315695e">315695e</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/19702">#19702</a> <a href="https://redirect.github.com/vitejs/vite/issues/19704">#19704</a></li> </ul> <h2><!-- raw HTML omitted -->4.5.9 (2025-01-21)<!-- raw HTML omitted --></h2> <ul> <li>fix: <code>preview.allowedHosts</code> with specific values was not respected (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19246">#19246</a>) (<a href="https://github.com/vitejs/vite/commit/0bc52e0">0bc52e0</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/19246">#19246</a></li> <li>fix: allow CORS from loopback addresses by default (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19249">#19249</a>) (<a href="https://github.com/vitejs/vite/commit/8f63cd6">8f63cd6</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/19249">#19249</a></li> </ul> <h2><!-- raw HTML omitted -->4.5.8 (2025-01-20)<!-- raw HTML omitted --></h2> <ul> <li>fix: try parse <code>server.origin</code> URL (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19241">#19241</a>) (<a href="https://github.com/vitejs/vite/commit/3680bad">3680bad</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/19241">#19241</a></li> </ul> <h2><!-- raw HTML omitted -->4.5.7 (2025-01-20)<!-- raw HTML omitted --></h2> <ul> <li>fix: <code>crypto.getRandomValues</code> is not available in old Node versions (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19237">#19237</a>) (<a href="https://github.com/vitejs/vite/commit/f4d3c46">f4d3c46</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/19237">#19237</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vitejs/vite/commit/9bfe2b1bc5d755cd7898d17147b9a1bb7f55fed2"><code>9bfe2b1</code></a> release: v4.5.14</li> <li><a href="https://github.com/vitejs/vite/commit/7739479d87330b367c9338b732ed9789871082cc"><code>7739479</code></a> fix: backport <a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19965">#19965</a>, check static serve file inside sirv (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19967">#19967</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/99afb601e9d5d6cad25b38f44ce4c02083dbcb62"><code>99afb60</code></a> chore: run format</li> <li><a href="https://github.com/vitejs/vite/commit/cd60e8bb2e354ca03d2e5e5b0d0a151cf40698e2"><code>cd60e8b</code></a> release: v4.5.13</li> <li><a href="https://github.com/vitejs/vite/commit/41f3819c869b86aec02e760fd3dabd5e370db284"><code>41f3819</code></a> fix: backport <a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19830">#19830</a>, reject requests with <code>#</code> in request-target (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19832">#19832</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/6104add2ed0204b9821f73dc230f9c05caaad405"><code>6104add</code></a> release: v4.5.12</li> <li><a href="https://github.com/vitejs/vite/commit/0a3dcf5875de6bcea64e2f75bfa452740ca3dfb0"><code>0a3dcf5</code></a> fix: backport <a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19782">#19782</a>, fs check with svg and relative paths (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19785">#19785</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/07ddc3ea3e5750f4761169064be87122f9b698f1"><code>07ddc3e</code></a> release: v4.5.11</li> <li><a href="https://github.com/vitejs/vite/commit/26e1764d54e7440d90226ebb82acbed457807d30"><code>26e1764</code></a> fix: backport <a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19761">#19761</a>, fs check in transform middleware (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/19763">#19763</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/86e7a6b8e40cd2fd545744b82b2bc805ced92847"><code>86e7a6b</code></a> release: v4.5.10</li> <li>Additional commits viewable in <a href="https://github.com/vitejs/vite/commits/v4.5.14/packages/vite">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/AzureAD/microsoft-authentication-library-for-js/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Logs and reports in telemetry whether there are multiple instances of MSAL in the same frame and if there are multiple instances with the same client id
- Gracefully handle old interaction format
PR to run CI against #7710 and get it merged into dev. Thanks @rm-eth-a-n for making the changes --------- Co-authored-by: rm-eth-a-n <[email protected]> Co-authored-by: Herman Jensen <[email protected]>
A couple of changes to fix the broken E2E tests and make tests a bit more reliable going forward
This PR adds a new public facing API isPlatformBrokerAvailable() that lets the client app check if platform broker is available for to acquire tokens natively. The method checks if brokering is available via DOM APIs or the browser extension. --------- Co-authored-by: Sameera Gajjarapu <[email protected]> Co-authored-by: Thomas Norling <[email protected]>
- Update logout doc in accordance with ESTS that always prompts the user to select the account for /v2/logout endpoint if no account is passed to the logout API. --------- Co-authored-by: Thomas Norling <[email protected]>
…tion-library-for-js into merge-v5-to-dev-5-13-25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Related to documentation.
extensions
Related to extensions for the base libraries
msal-angular
Related to @azure/msal-angular package
msal-browser
Related to msal-browser package
msal-common
Related to msal-common package
msal-node
Related to msal-node package
msal-react
Related to @azure/msal-react
samples
Related to the samples apps for the library.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.