Skip to content

Plugin XPC related UI into MSAL Mac Sample app and update commonCore #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kaisong1990 merged 17 commits into from
May 16, 2025
Merged

Plugin XPC related UI into MSAL Mac Sample app and update commonCore #2571

kaisong1990 merged 17 commits into from
May 16, 2025

Conversation

@kaisong1990
Copy link
Contributor

@kaisong1990 kaisong1990 commented Apr 3, 2025 •
edited
Loading

Screenshot 2025-05-14 at 3 04 37 PM

Proposed changes

Add new UI in Mac sample app to support XPC switch

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@kaisong1990 kaisong1990 requested review from a team as code owners April 3, 2025 21:52
@kaisong1990 kaisong1990 added the XPC label Apr 3, 2025
hieunguyenmsft
hieunguyenmsft approved these changes May 14, 2025
View reviewed changes
@hieunguyenmsft hieunguyenmsft self-requested a review May 15, 2025 16:40
antrix1989
antrix1989 reviewed May 15, 2025
View reviewed changes
@kaisong1990 kaisong1990 merged commit 13eccf3 into dev May 16, 2025
13 checks passed
@kaisong1990 kaisong1990 deleted the kasong/2914053-common-interface branch May 16, 2025 20:04
@azure-pipelines azure-pipelines bot mentioned this pull request May 18, 2025
Closed
@azure-pipelines azure-pipelines bot mentioned this pull request May 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antrix1989 antrix1989 antrix1989 approved these changes

@hieunguyenmsft hieunguyenmsft hieunguyenmsft approved these changes

@fidelianawar fidelianawar Awaiting requested review from fidelianawar fidelianawar is a code owner automatically assigned from AzureAD/appleidentityteam

Assignees

No one assigned

Labels

XPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaisong1990 @antrix1989 @hieunguyenmsft