Skip to content

Replaced JIT with Register Strong Auth #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025

Conversation

spetrescu84
Copy link
Contributor

Proposed changes

Replaced occurrences of the word "JIT" with "Register Strong Auth" whenever present in logs.
Formatted logs around JIT to be more clear.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

Sorry, something went wrong.

@spetrescu84 spetrescu84 self-assigned this Apr 30, 2025
@spetrescu84 spetrescu84 requested a review from a team as a code owner April 30, 2025 09:57
@@ -82,7 +82,7 @@ final class MSALNativeAuthJITController: MSALNativeAuthBaseController, MSALNativ
MSALNativeAuthLogger.logPII(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

# Conflicts:
#	MSAL/src/native_auth/controllers/sign_in/MSALNativeAuthSignInController.swift
@spetrescu84 spetrescu84 requested a review from a team as a code owner May 15, 2025 16:36
@spetrescu84 spetrescu84 merged commit 3a1543d into dev May 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants