Skip to content

[patch][eng]: Update submodule to latest version - #3029

Open
juan-arias wants to merge 1 commit into
devfrom
jarias/mobile-onboarding-in-progress-session-fixes
Open

[patch][eng]: Update submodule to latest version#3029
juan-arias wants to merge 1 commit into
devfrom
jarias/mobile-onboarding-in-progress-session-fixes

Conversation

@juan-arias

Copy link
Copy Markdown
Contributor

PR Checklist (must be completed before review)

  • All tests pass locally
  • PR size is <= 500 LOC per PR Size Check policy
  • PR is independently mergeable (no hidden dependencies)
  • Appropriate reviewers are assigned
  • PR reviewed by code owner (required if Copilot-generated)
  • SME or Senior IC assigned where required

Proposed changes

This pull request updates the MSAL/IdentityCore submodule to a newer commit. This change brings in the latest updates from the IdentityCore dependency, which may include bug fixes, improvements, or new features.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

Comment thread MSAL/IdentityCore
@@ -1 +1 @@
Subproject commit 6c4d155c98bfc0553482e6684ebdc16a86201314

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the MSAL/IdentityCore git submodule pointer to bring in a newer revision of the IdentityCore dependency (AzureAD/microsoft-authentication-library-common-for-objc), updating what code MSAL consumes from the shared common library.

Changes:

  • Bump MSAL/IdentityCore submodule from 6c4d155c98bfc0553482e6684ebdc16a86201314 to aca95b2137d26f21cc36bbd1d144a1ee60671571.

Comment thread MSAL/IdentityCore
@@ -1 +1 @@
Subproject commit 6c4d155c98bfc0553482e6684ebdc16a86201314
Subproject commit aca95b2137d26f21cc36bbd1d144a1ee60671571

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This range also ships MSIDBoundTokenProvider, but acquireBoundTokenWithRequest: only returns metadata JSON with error == nil; it never redeems or obtains a token. The silent-routing follow-up is still open (CommonCore #1875), and interactive acquisition remains stubbed, so a OneAuth caller can treat an unusable non-token payload as successful authentication. Please keep this provider out of the MSAL pointer, gate it, or return an explicit unsupported error until the real flow lands.

Comment thread MSAL/IdentityCore
@@ -1 +1 @@
Subproject commit 6c4d155c98bfc0553482e6684ebdc16a86201314
Subproject commit aca95b2137d26f21cc36bbd1d144a1ee60671571

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aca95b2 is only on jarias/mobile-onboarding-in-progress-session-fixes; it is not an ancestor of CommonCore dev, which also explains the failing submodule policy check. Merging this would pin MSAL to an unmerged feature-branch commit that can become orphaned and is outside the approved dependency line. Please land the CommonCore changes first, then repoint this gitlink to the resulting dev commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants