-
Notifications
You must be signed in to change notification settings - Fork 163
Implement V2 (HAL-based) SSPR flow for native auth #3057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spetrescu84
wants to merge
87
commits into
sedemche/native-auth-v2_release
Choose a base branch
from
spetrescu/native-auth-v2-sspr
base: sedemche/native-auth-v2_release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,346
−334
Open
Changes from 84 commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
26aff0c
Add Native Auth V2 (server-driven HAL) SDK with SSPR wired end-to-end
spetrescu84 51e0626
hal responses
spetrescu84 e90c15f
other flows - sign-in/sign-up, parsing urls properly
spetrescu84 c72464b
url resolver
spetrescu84 365df84
Updates for error handling and proper signin response
spetrescu84 f5cb672
parse token
spetrescu84 90bcb7f
Fix sending attributes
spetrescu84 6a9af74
Move HAL to MSAL
spetrescu84 2e74940
v2 client_info and parameters and scopes
spetrescu84 1f5e017
Reorder items in PublicClientApplication
spetrescu84 48ef139
flow controller swiftlint
spetrescu84 645db2b
Swiftlint
spetrescu84 2590b88
comments
spetrescu84 17e18ed
Native Auth V2: early link validation, non-optional hrefs, method ord…
spetrescu84 77810a0
decode response and fail rther than failing on next request
spetrescu84 78e2ac8
Removed static and Self. calls
spetrescu84 ce51bab
Fail fast on missing authorize-challenge link; thread flowType into V…
spetrescu84 4d55fc3
Added ApiId for each endpoint that is the same
spetrescu84 75d5f23
Refine V2 flow controller: naming, hint fallback, and per-link error …
spetrescu84 0956214
Extract shared token-response cache persistence into MSALNativeAuthTo…
spetrescu84 15ec8dd
Deduplicate native-auth controllers and wire HAL isError propagation
spetrescu84 396d7e7
Drop redundant HAL isError in favor of direct error binding
spetrescu84 1de98f6
MFA
spetrescu84 6b44812
SignUp changes
spetrescu84 17cc92c
Native Auth V2: sign-up attribute autofill + otp verify fixes
spetrescu84 8c380d4
Merge origin/sedemche/native-auth-v2_release into origin/spetrescu/na…
spetrescu84 5fb022d
Alignment for v1 and v2 interfaces for parameters and SOLID principles
spetrescu84 b4a4500
Refactor V2 native-auth to use typed key enums (V1-style)
spetrescu84 d9ee86b
Introduce typed body for V2 native-auth HAL follow-up requests
spetrescu84 c616084
Add context-threaded, PII-masked logging to V2 native-auth validator …
spetrescu84 574e3e0
Add version control rule: never commit or push without explicit user …
spetrescu84 78ac89a
Fix V2 FlowController completion tests and resolve SwiftLint issues
spetrescu84 8c495d0
Merge branch 'dev' into spetrescu/native-auth-v2
spetrescu84 f4c100f
merged dev into branch
spetrescu84 608c98a
Revert "merged dev into branch"
spetrescu84 8753280
Correct IC
spetrescu84 32094fc
Revert "Correct IC"
spetrescu84 bf2b80e
removed not needed cache accessor
spetrescu84 0d127ad
not needed comment
spetrescu84 3f21006
Comments
spetrescu84 ab433a1
Unify V2 continuation-state links behind a typed LinkKey
spetrescu84 a74b7ac
Remove KVC body hack from V2 request configurator
spetrescu84 00c6ccc
Updates to code guides
spetrescu84 0fd300f
Removed rule from agents.md
spetrescu84 5026f8d
removed not necessary imports
spetrescu84 96fca30
Avoid non-Sendable captures in native-auth request continuations
spetrescu84 27cbbfb
Removed not necessary imports
spetrescu84 839f384
Renamed makeV2FlowController to makeFlowController
spetrescu84 6815fa5
Removed import
spetrescu84 a8432ee
Route reset-password challenge/resend through server-driven mapIntera…
spetrescu84 5dbbbe9
Route reset-password code verification through server-driven mapInter…
spetrescu84 a0b18d8
MFA
spetrescu84 18a1408
Treat invalid continuation token as a general error
spetrescu84 606a0be
Comments
spetrescu84 c69737e
Comment
spetrescu84 1bbbdab
Remove unused V2 HAL token validator
spetrescu84 2fa2181
Fold sign-in method discovery into the interaction action switch
spetrescu84 9438988
Comments
spetrescu84 8ec1d8a
Comments
spetrescu84 48727b8
Comments
spetrescu84 57547e6
Comment
spetrescu84 2945caf
comment
spetrescu84 af477fa
Map password policy and credentials errors in V2 flow error mapper
spetrescu84 9ce847f
Merge branch 'sedemche/native-auth-v2_release' into spetrescu/native-…
spetrescu84 948f61b
Replace native-auth V2 action enum with concrete states and server-dr…
spetrescu84 18f46d5
Thread operation apiId into V2 native-auth requests
spetrescu84 48a173a
Add V2 native-auth network unit tests and fix stale controller test
spetrescu84 71700ae
Add V2 native-auth Tier 1 tests: FlowError, dispatcher, HAL serialize…
spetrescu84 1711f5b
Remove non sspr
spetrescu84 2bfaf0b
moved RetryExecutor to main to use in poll SSPR
spetrescu84 0a2b0a4
setup MSALNativeAuthFlowScenario as case iterable
spetrescu84 29f5e8d
remove not used cache accessor
spetrescu84 b400f53
Removed deprecated messages
spetrescu84 8e77419
made mapInteraction testable and added tests
spetrescu84 86394ce
Add redirect back
spetrescu84 2237fe6
Added clarification comment
spetrescu84 c83c369
Rename V2 response validator to parser
spetrescu84 baf9a91
Add todo to MSALNativeAuthV2HrefURLResolver
spetrescu84 e75d8ab
Make V2 LinkRelation an extensible struct and prune unused relations
spetrescu84 9edc2d3
Moved all endpoints into one enum
spetrescu84 010291b
Update flow controller to remove mapInteraction
spetrescu84 9e04a46
removed TokenCacher and moved to MSALNativeAuthCacheInterface
spetrescu84 77bbc6c
Split MSALNativeAuthV2RequestBody into per request
spetrescu84 7f08618
Split MSALNativeAuthHALResponse by request
spetrescu84 5cce4cf
Fix build issues
spetrescu84 caecbd4
Update HalAction
spetrescu84 c6f3d1b
First check for error before guard poll
spetrescu84 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not update CHANGELOG.md.
Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.