-
Notifications
You must be signed in to change notification settings - Fork 206
MSAL Python 1.27 #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSAL Python 1.27 #669
Conversation
* Update issue templates * Update feature_request.md * Update feature_request.md * Remove excess spaces, and rename .md to .yaml --------- Co-authored-by: Ray Luo <[email protected]>
Order scopes on save, and optimize the happy path for access token read
Tolerate ID token time errors
Give a hint on where the client_id came from
This is needed because our org has transitioned to a read-only GITHUB_TOKEN for GitHub Action workflows. This change fixes #653
Using a bare except statement when importing hides other errors, which then get lost when the next import fails. Co-authored-by: Ed Singleton <[email protected]>
@@ -70,7 +70,7 @@ | |||
headers={'Authorization': 'Bearer ' + result['access_token']},).json() | |||
print("Graph API call result: %s" % json.dumps(graph_data, indent=2)) | |||
else: | |||
print("Token acquisition failed") # Examine result["error_description"] etc. to diagnose error | |||
print("Token acquisition failed", result) # Examine result["error_description"] etc. to diagnose error |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
@@ -69,7 +69,7 @@ | |||
headers={'Authorization': 'Bearer ' + result['access_token']},).json() | |||
print("Graph API call result: %s" % json.dumps(graph_data, indent=2)) | |||
else: | |||
print("Token acquisition failed") # Examine result["error_description"] etc. to diagnose error | |||
print("Token acquisition failed", result) # Examine result["error_description"] etc. to diagnose error |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
@@ -91,7 +91,7 @@ | |||
headers={'Authorization': 'Bearer ' + result['access_token']},).json() | |||
print("Graph API call result: %s" % json.dumps(graph_data, indent=2)) | |||
else: | |||
print("Token acquisition failed") # Examine result["error_description"] etc. to diagnose error | |||
print("Token acquisition failed", result) # Examine result["error_description"] etc. to diagnose error |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
@@ -86,7 +86,7 @@ | |||
headers={'Authorization': 'Bearer ' + result['access_token']},) | |||
print("Graph API call result: %s ..." % graph_response.text[:100]) | |||
else: | |||
print("Token acquisition failed") # Examine result["error_description"] etc. to diagnose error | |||
print("Token acquisition failed", result) # Examine result["error_description"] etc. to diagnose error |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
@@ -73,8 +75,7 @@ | |||
headers={'Authorization': 'Bearer ' + result['access_token']},).json() | |||
print("Graph API call result: %s" % json.dumps(graph_data, indent=2)) | |||
else: | |||
print("Token acquisition failed") # Examine result["error_description"] etc. to diagnose error | |||
print(result) | |||
print("Token acquisition failed", result) # Examine result["error_description"] etc. to diagnose error |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
@@ -132,7 +132,7 @@ | |||
headers={'Authorization': 'Bearer ' + result['access_token']},).json() | |||
print("Graph API call result: %s" % json.dumps(graph_data, indent=2)) | |||
else: | |||
print("Token acquisition failed") # Examine result["error_description"] etc. to diagnose error | |||
print("Token acquisition failed", result) # Examine result["error_description"] etc. to diagnose error |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
) if authority and not authority.startswith( | ||
"https://login.microsoftonline.com") else None |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization
Release Notes:
remove_tokens_for_client()
will remove tokens acquired byacquire_token_for_client()
(Feature Request: Removing app tokens #640, [Feature Request] Supportforce_refresh
for service principal #650, Implement remove_tokens_for_client() #666)localhost
is accessed using HTTPS #546)except
clause (Don't use bare except when importing #667)Note:
1.27.0b2
requires more beta testing, so they did NOT make it to1.27.0
. If you want to beta test1.27.0b2
, follow its own instruction.