Fix losing certificates for credentials with CredentialSource.Certificate#3711
Open
pentp wants to merge 1 commit intoAzureAD:masterfrom
Open
Fix losing certificates for credentials with CredentialSource.Certificate#3711pentp wants to merge 1 commit intoAzureAD:masterfrom
CredentialSource.Certificate#3711pentp wants to merge 1 commit intoAzureAD:masterfrom
Conversation
bgavrilMS
reviewed
Feb 6, 2026
|
|
||
| if (credentialDescription.CachedValue == null) | ||
| if (credentialDescription.CachedValue == null | ||
| && (credentialDescription.SourceType == CredentialSource.CustomSignedAssertion || CredentialSourceLoaders.ContainsKey(credentialDescription.SourceType))) |
Author
There was a problem hiding this comment.
This is principally for CredentialSource.Certificate - it doesn't have an associated loader and its CachedValue will always be null, so this just skips the semaphore setup and locking entirely.
bgavrilMS
reviewed
Feb 6, 2026
| { | ||
| foreach (var credentialDescription in credentialDescriptions) | ||
| { | ||
| credentialDescription.CachedValue = null; |
Member
There was a problem hiding this comment.
I think we would need unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultCertificateLoader.ResetCertificatesincorrectly resets certificates forCredentialSource.Certificatewhich causes extremely confusing and hard to debug errors about null certificates later.Also cleaned up a bit of redundant code.